linux-kernel - Re: [PATCH] spi: spi-axi-spi-engine: Access register after clock initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <a21ea696ceccf55696f0561d7b3931a104b72b3d.camel@analog.com>
Date:   Thu, 9 Apr 2020 15:26:41 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "linux-spi@...r.kernel.org" <linux-spi@...r.kernel.org>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "rafal.hibner@...om.com.pl" <rafal.hibner@...om.com.pl>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] spi: spi-axi-spi-engine: Access register after clock
 initialization


On Thu, 2020-04-09 at 17:23 +0200, Rafał Hibner wrote:
> [External]
> 
> Move register access after clock initialization.
> 
> Clock "s_axi_aclk" is needed for register access. Without the clock running
> 
> AXI bus hangs and causes kernel freeze.
> 

This email looks like it has HTML formatting.

Can you switch to [and use only] plain-text?


Out of curiosity: did you use the 'git send-email' command for this patch?


> Cc: Alexandru Ardelean <alexandru.ardelean@...log.com>
> 
> Signed-off-by: Rafał Hibner <rafal.hibner@...om.com.pl>
> 
> ---
> 
>  drivers/spi/spi-axi-spi-engine.c | 32 ++++++++++++++++----------------
> 
>  1 file changed, 16 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/spi/spi-axi-spi-engine.c b/drivers/spi/spi-axi-spi-
> engine.c
> 
> index eb9b78a90d..af86e6d6e1 100644
> 
> --- a/drivers/spi/spi-axi-spi-engine.c
> 
> +++ b/drivers/spi/spi-axi-spi-engine.c
> 
> @@ -489,22 +489,6 @@ static int spi_engine_probe(struct platform_device *pdev)
> 
>  
> 
>   spin_lock_init(&spi_engine->lock);
> 
>  
> 
> - spi_engine->base = devm_platform_ioremap_resource(pdev, 0);
> 
> - if (IS_ERR(spi_engine->base)) {
> 
> - ret = PTR_ERR(spi_engine->base);
> 
> - goto err_put_master;
> 
> - }
> 
> -
> 
> - version = readl(spi_engine->base + SPI_ENGINE_REG_VERSION);
> 
> - if (SPI_ENGINE_VERSION_MAJOR(version) != 1) {
> 
> - dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%c\n",
> 
> - SPI_ENGINE_VERSION_MAJOR(version),
> 
> - SPI_ENGINE_VERSION_MINOR(version),
> 
> - SPI_ENGINE_VERSION_PATCH(version));
> 
> - ret = -ENODEV;
> 
> - goto err_put_master;
> 
> - }
> 
> -
> 
>   spi_engine->clk = devm_clk_get(&pdev->dev, "s_axi_aclk");
> 
>   if (IS_ERR(spi_engine->clk)) {
> 
>   ret = PTR_ERR(spi_engine->clk);
> 
> @@ -525,6 +509,22 @@ static int spi_engine_probe(struct platform_device *pdev)
> 
>   if (ret)
> 
>   goto err_clk_disable;
> 
>  
> 
> + spi_engine->base = devm_platform_ioremap_resource(pdev, 0);
> 
> + if (IS_ERR(spi_engine->base)) {
> 
> + ret = PTR_ERR(spi_engine->base);
> 
> + goto err_ref_clk_disable;
> 
> + }
> 
> +
> 
> + version = readl(spi_engine->base + SPI_ENGINE_REG_VERSION);
> 
> + if (SPI_ENGINE_VERSION_MAJOR(version) != 1) {
> 
> + dev_err(&pdev->dev, "Unsupported peripheral version %u.%u.%c\n",
> 
> + SPI_ENGINE_VERSION_MAJOR(version),
> 
> + SPI_ENGINE_VERSION_MINOR(version),
> 
> + SPI_ENGINE_VERSION_PATCH(version));
> 
> + ret = -ENODEV;
> 
> + goto err_ref_clk_disable;
> 
> + }
> 
> +
> 
>   writel_relaxed(0x00, spi_engine->base + SPI_ENGINE_REG_RESET);
> 
>   writel_relaxed(0xff, spi_engine->base + SPI_ENGINE_REG_INT_PENDING);
> 
>   writel_relaxed(0x00, spi_engine->base + SPI_ENGINE_REG_INT_ENABLE);
> 
> --
> 
> 2.24.1
>