linux-kernel - Re: [PATCH] nfp: Fix memory leak in nfp_resource

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAEYrHjkjYESXHG1x0Obnz+T5xv00vyZKHzUg=ZC70f0JymSU=g@mail.gmail.com>
Date:   Fri, 10 Apr 2020 02:38:35 +0900
From:   Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
To:     David Miller <davem@...emloft.net>
Cc:     Kubota Takafumi <takafumi.kubota1012@...ab.ics.keio.ac.jp>,
        Jakub Kicinski <kuba@...nel.org>,
        "open list:NETRONOME ETHERNET DRIVERS" <oss-drivers@...ronome.com>,
        "open list:NETWORKING DRIVERS" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] nfp: Fix memory leak in nfp_resource_acquire()

Hi,

So sorry about this. It seems like I accidentally touched the patch
file after generating / testing the patch.
I will resend the new patch immediately.

I have tested the patch using kmemleak.

Thanks.

2020年4月10日(金) 2:18 David Miller <davem@...emloft.net>:
>
> From: Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
> Date: Thu,  9 Apr 2020 15:02:07 +0000
>
> > This patch fixes a memory leak in nfp_resource_acquire(). res->mutex is
> > alllocated in nfp_resource_try_acquire(). However, when
> > msleep_interruptible() or time_is_before_eq_jiffies() fails, it falls
> > into err_fails path where res is freed, but res->mutex is not.
> >
> > Fix this by changing call to free to nfp_resource_release().
> >
> > Signed-off-by: Keita Suzuki <keitasuzuki.park@...ab.ics.keio.ac.jp>
>
> Did you test compile this?
>
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c: In function ‘nfp_resource_acquire’:
> drivers/net/ethernet/netronome/nfp/nfpcore/nfp_resource.c:203:2: error: implicit declaration of function ‘nfp_resource_relase’; did you mean ‘nfp_resource_release’? [-Werror=implicit-function-declaration]
>   nfp_resource_relase(res);
>   ^~~~~~~~~~~~~~~~~~~
>   nfp_resource_release
>
> And this makes me feel like the test was not runtime tested either.