linux-kernel - Re: [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200409205924.GO17661@paulmck-ThinkPad-P72>
Date:   Thu, 9 Apr 2020 13:59:24 -0700
From:   "Paul E. McKenney" <paulmck@...nel.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     dave@...olabs.net, josh@...htriplett.org, rostedt@...dmis.org,
        mathieu.desnoyers@...icios.com, jiangshanlai@...il.com,
        joel@...lfernandes.org, linux-kernel@...r.kernel.org,
        rcu@...r.kernel.org
Subject: Re: [PATCH] rcutorture: make rcu_fwds and rcu_fwd_emergency_stop
 static

On Thu, Apr 09, 2020 at 07:42:38PM +0800, Jason Yan wrote:
> Fix the following sparse warning:
> 
> kernel/rcu/rcutorture.c:1695:16: warning: symbol 'rcu_fwds' was not
> declared. Should it be static?
> kernel/rcu/rcutorture.c:1696:6: warning: symbol 'rcu_fwd_emergency_stop'
> was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Good catch, queued, thank you!

							Thanx, Paul

> ---
>  kernel/rcu/rcutorture.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/rcu/rcutorture.c b/kernel/rcu/rcutorture.c
> index 5453bd557f43..d621a31de8a4 100644
> --- a/kernel/rcu/rcutorture.c
> +++ b/kernel/rcu/rcutorture.c
> @@ -1692,8 +1692,8 @@ struct rcu_fwd {
>  	unsigned long rcu_launder_gp_seq_start;
>  };
>  
> -struct rcu_fwd *rcu_fwds;
> -bool rcu_fwd_emergency_stop;
> +static struct rcu_fwd *rcu_fwds;
> +static bool rcu_fwd_emergency_stop;
>  
>  static void rcu_torture_fwd_cb_hist(struct rcu_fwd *rfp)
>  {
> -- 
> 2.17.2
>