linux-kernel - Re: [PATCH 1/1] smack: remove redundant structure variable from header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <91af6ae1-919a-bc48-1f62-6ba3b4c62dac@schaufler-ca.com>
Date:   Thu, 9 Apr 2020 14:00:13 -0700
From:   Casey Schaufler <casey@...aufler-ca.com>
To:     Maninder Singh <maninder1.s@...sung.com>, jmorris@...ei.org,
        serge@...lyn.com
Cc:     linux-security-module@...r.kernel.org,
        linux-kernel@...r.kernel.org, a.sahrawat@...sung.com,
        v.narang@...sung.com, Casey Schaufler <casey@...aufler-ca.com>
Subject: Re: [PATCH 1/1] smack: remove redundant structure variable from
 header.

On 4/9/2020 5:39 AM, Maninder Singh wrote:
> commit afb1cbe37440 ("LSM: Infrastructure management
> of the inode security") removed usage of smk_rcu,
> thus removing it from structure.
>
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Vaneet Narang <v.narang@...sung.com>

Thank you. I will take this.

> ---
>  security/smack/smack.h | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/security/smack/smack.h b/security/smack/smack.h
> index 62529f3..5ebd0bb 100644
> --- a/security/smack/smack.h
> +++ b/security/smack/smack.h
> @@ -111,7 +111,6 @@ struct inode_smack {
>  	struct smack_known	*smk_mmap;	/* label of the mmap domain */
>  	struct mutex		smk_lock;	/* initialization lock */
>  	int			smk_flags;	/* smack inode flags */
> -	struct rcu_head         smk_rcu;	/* for freeing inode_smack */
>  };
>  
>  struct task_smack {