linux-kernel - Re: [PATCH] x86/mm/init: Stop printing pgt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cd67ee35-9082-9baf-1d11-598064580f49@intel.com>
Date:   Thu, 9 Apr 2020 15:35:08 -0700
From:   Dave Hansen <dave.hansen@...el.com>
To:     Arvind Sankar <nivedita@...m.mit.edu>
Cc:     "Tobin C . Harding" <me@...in.cc>, Tycho Andersen <tycho@...ho.ws>,
        kernel-hardening@...ts.openwall.com,
        Kees Cook <keescook@...omium.org>,
        Andy Lutomirski <luto@...nel.org>,
        Peter Zijlstra <peterz@...radead.org>, x86@...nel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86/mm/init: Stop printing pgt_buf addresses

On 4/9/20 3:19 PM, Arvind Sankar wrote:
>> @@ -121,8 +121,6 @@ __ref void *alloc_low_pages(unsigned int num)
>>  	} else {
>>  		pfn = pgt_buf_end;
>>  		pgt_buf_end += num;
>> -		printk(KERN_DEBUG "BRK [%#010lx, %#010lx] PGTABLE\n",
>> -			pfn << PAGE_SHIFT, (pgt_buf_end << PAGE_SHIFT) - 1);
>>  	}
>>  
>>  	for (i = 0; i < num; i++) {
>> -- 
>> 2.24.1
>>
> This was acked by Kees, is it ok for merge?

Independent of the obvious security implications, I don't think I've
ever once gleaned useful information from that message.  It's fine by me.

Acked-by: Dave Hansen <dave.hansen@...el.com>