linux-kernel - Re: [PATCH 2/3] platform/chrome: typec: Add struct for port data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200409223950.GB15090@google.com>
Date:   Thu, 9 Apr 2020 15:39:50 -0700
From:   Prashant Malani <pmalani@...omium.org>
To:     Enric Balletbo i Serra <enric.balletbo@...labora.com>
Cc:     linux-kernel@...r.kernel.org, heikki.krogerus@...ux.intel.com,
        Benson Leung <bleung@...omium.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH 2/3] platform/chrome: typec: Add struct for port data

Thanks Enric,

On Thu, Apr 09, 2020 at 11:19:51PM +0200, Enric Balletbo i Serra wrote:
> Hi Prashant,
> 
> Thank you for the patch.
> 
> On 7/4/20 3:09, Prashant Malani wrote:
> > Add a separate struct for storing port data, including Type C connector
> > class struct pointers and caps.
> > 
> > Signed-off-by: Prashant Malani <pmalani@...omium.org>
> > ---
> >  drivers/platform/chrome/cros_ec_typec.c | 49 ++++++++++++++++---------
> >  1 file changed, 32 insertions(+), 17 deletions(-)
> > 
> > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c
> > index cf7c2652a1d6d..1955e1dfebc6d 100644
> > --- a/drivers/platform/chrome/cros_ec_typec.c
> > +++ b/drivers/platform/chrome/cros_ec_typec.c
> > @@ -17,6 +17,13 @@
> >  
> >  #define DRV_NAME "cros-ec-typec"
> >  
> > +/* Per port data. */
> > +struct cros_typec_port {
> > +	struct typec_port *port;
> > +	/* Initial capabilities for the port. */
> > +	struct typec_capability caps;
> > +};
> > +
> >  /* Platform-specific data for the Chrome OS EC Type C controller. */
> >  struct cros_typec_data {
> >  	struct device *dev;
> > @@ -24,9 +31,7 @@ struct cros_typec_data {
> >  	int num_ports;
> >  	unsigned int cmd_ver;
> >  	/* Array of ports, indexed by port number. */
> > -	struct typec_port *ports[EC_USB_PD_MAX_PORTS];
> > -	/* Initial capabilities for each port. */
> > -	struct typec_capability *caps[EC_USB_PD_MAX_PORTS];
> > +	struct cros_typec_port *ports[EC_USB_PD_MAX_PORTS];
> >  	struct notifier_block nb;
> >  };
> >  
> > @@ -76,14 +81,26 @@ static int cros_typec_parse_port_props(struct typec_capability *cap,
> >  	return 0;
> >  }
> >  
> > +static void cros_unregister_ports(struct cros_typec_data *typec)
> > +{
> > +	int i;
> > +
> > +	for (i = 0; i < typec->num_ports; i++) {
> > +		if (!typec->ports[i])
> > +			continue;
> > +		typec_unregister_port(typec->ports[i]->port);
> > +		devm_kfree(typec->dev, typec->ports[i]);
> 
> This is not needed, the allocated memory is device managed, so will be freed on
> removal or error.
> 
Got it. Will make the change.
> > +	}
> > +}
> > +
> >  static int cros_typec_init_ports(struct cros_typec_data *typec)
> >  {
> >  	struct device *dev = typec->dev;
> >  	struct typec_capability *cap;
> >  	struct fwnode_handle *fwnode;
> > +	struct cros_typec_port *cros_port;
> >  	const char *port_prop;
> >  	int ret;
> > -	int i;
> >  	int nports;
> >  	u32 port_num = 0;
> >  
> > @@ -115,22 +132,23 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
> >  
> >  		dev_dbg(dev, "Registering port %d\n", port_num);
> >  
> > -		cap = devm_kzalloc(dev, sizeof(*cap), GFP_KERNEL);
> > -		if (!cap) {
> > +		cros_port = devm_kzalloc(dev, sizeof(*cros_port), GFP_KERNEL);
> > +		if (!cros_port) {
> >  			ret = -ENOMEM;
> >  			goto unregister_ports;
> >  		}
> >  
> > -		typec->caps[port_num] = cap;
> > +		typec->ports[port_num] = cros_port;
> > +		cap = &cros_port->caps;
> >  
> >  		ret = cros_typec_parse_port_props(cap, fwnode, dev);
> >  		if (ret < 0)
> >  			goto unregister_ports;
> >  
> > -		typec->ports[port_num] = typec_register_port(dev, cap);
> > -		if (IS_ERR(typec->ports[port_num])) {
> > +		cros_port->port = typec_register_port(dev, cap);
> > +		if (IS_ERR(cros_port->port)) {
> >  			dev_err(dev, "Failed to register port %d\n", port_num);
> > -			ret = PTR_ERR(typec->ports[port_num]);
> > +			ret = PTR_ERR(cros_port->port);
> >  			goto unregister_ports;
> >  		}
> >  	}
> > @@ -138,8 +156,7 @@ static int cros_typec_init_ports(struct cros_typec_data *typec)
> >  	return 0;
> >  
> >  unregister_ports:
> > -	for (i = 0; i < typec->num_ports; i++)
> > -		typec_unregister_port(typec->ports[i]);
> > +	cros_unregister_ports(typec);
> >  	return ret;
> >  }
> >  
> > @@ -177,7 +194,7 @@ static int cros_typec_ec_command(struct cros_typec_data *typec,
> >  static void cros_typec_set_port_params_v0(struct cros_typec_data *typec,
> >  		int port_num, struct ec_response_usb_pd_control *resp)
> >  {
> > -	struct typec_port *port = typec->ports[port_num];
> > +	struct typec_port *port = typec->ports[port_num]->port;
> >  	enum typec_orientation polarity;
> >  
> >  	if (!resp->enabled)
> > @@ -194,7 +211,7 @@ static void cros_typec_set_port_params_v0(struct cros_typec_data *typec,
> >  static void cros_typec_set_port_params_v1(struct cros_typec_data *typec,
> >  		int port_num, struct ec_response_usb_pd_control_v1 *resp)
> >  {
> > -	struct typec_port *port = typec->ports[port_num];
> > +	struct typec_port *port = typec->ports[port_num]->port;
> >  	enum typec_orientation polarity;
> >  
> >  	if (!(resp->enabled & PD_CTRL_RESP_ENABLED_CONNECTED))
> > @@ -360,9 +377,7 @@ static int cros_typec_probe(struct platform_device *pdev)
> >  	return 0;
> >  
> >  unregister_ports:
> > -	for (i = 0; i < typec->num_ports; i++)
> > -		if (typec->ports[i])
> > -			typec_unregister_port(typec->ports[i]);
> > +	cros_unregister_ports(typec);
> >  	return ret;
> >  }
> >  
> >