linux-kernel - RE: [PATCH v7 7/8] PCI: Add Renesas R8A774C0 device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 10 Apr 2020 00:12:38 +0000
From:   Yoshihiro Shimoda <yoshihiro.shimoda.uh@...esas.com>
To:     "Lad, Prabhakar" <prabhakar.csengg@...il.com>,
        Sergei Shtylyov <sergei.shtylyov@...entembedded.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
CC:     Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@...renesas.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Rob Herring <robh+dt@...nel.org>,
        Andrew Murray <amurray@...goodpenguin.co.uk>,
        Kishon Vijay Abraham I <kishon@...com>,
        Marek Vasut <marek.vasut+renesas@...il.com>,
        Gustavo Pimentel <gustavo.pimentel@...opsys.com>,
        Jingoo Han <jingoohan1@...il.com>,
        Shawn Lin <shawn.lin@...k-chips.com>,
        Tom Joseph <tjoseph@...ence.com>,
        Heiko Stuebner <heiko@...ech.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        linux-pci <linux-pci@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>, LKML <linux-kernel@...r.kernel.org>,
        LAK <linux-arm-kernel@...ts.infradead.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Chris Paterson <Chris.Paterson2@...esas.com>,
        "open list:ARM/Rockchip SoC..." <linux-rockchip@...ts.infradead.org>
Subject: RE: [PATCH v7 7/8] PCI: Add Renesas R8A774C0 device ID

Hi Prabhakar, Sergei, Bjorn,

> From: Lad, Prabhakar, Sent: Thursday, April 9, 2020 7:05 PM
<snip> 
> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > > index 1dfc4e1dcb94..9e957c18abeb 100644
> > > --- a/include/linux/pci_ids.h
> > > +++ b/include/linux/pci_ids.h
> > > @@ -2460,6 +2460,7 @@
> > >   #define PCI_DEVICE_ID_RENESAS_SH7763        0x0004
> > >   #define PCI_DEVICE_ID_RENESAS_SH7785        0x0007
> > >   #define PCI_DEVICE_ID_RENESAS_SH7786        0x0010
> > > +#define PCI_DEVICE_ID_RENESAS_R8A774C0       0x002d
> >
> >     We don't add the device IDs in this file, unless used in several places.
> > Is it?
> >
> My bad I should have checked it before making this change actually it
> was suggested in my previous version of the series but anyway atm this
> was planned to be  used only in pci_endpoint_test driver, so in that
> case Ill drop this patch.

I'm very sorry, this is my fault. I suggested this but I didn't check
this pci_ids.h's rule...

Best regards,
Yoshihiro Shimoda