linux-kernel - Re: [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hsghbn4eg.wl-tiwai@suse.de>
Date:   Fri, 10 Apr 2020 10:14:47 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Adam Barber <barberadam995@...il.com>
Cc:     tiwai@...e.com, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Enable the headset mic on Asus FX505DT

On Fri, 10 Apr 2020 02:55:33 +0200,
Adam Barber wrote:
> 
> On Asus FX505DT with Realtek ALC233, the headset mic is connected
> to pin 0x19, with default 0x411111f0.
> 
> Enable headset mic by reconfiguring the pin to an external mic
> associated with the headphone on 0x21. Mic jack detection was also
> found to be working.

Could you give your sign-off?  It's mandatory for merging to upstream.
Also, if there is some information linke (e.g. Bugzilla), put it in
"BugLink: $URL" line, too.


thanks,

Takashi


> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index f66a48154a57..5016fa50956a 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -7252,6 +7252,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x1043, 0x16e3, "ASUS UX50", ALC269_FIXUP_STEREO_DMIC),
>  	SND_PCI_QUIRK(0x1043, 0x17d1, "ASUS UX431FL", ALC294_FIXUP_ASUS_DUAL_SPK),
>  	SND_PCI_QUIRK(0x1043, 0x18b1, "Asus MJ401TA", ALC256_FIXUP_ASUS_HEADSET_MIC),
> +	SND_PCI_QUIRK(0x1043, 0x18f1, "Asus FX505DT", ALC256_FIXUP_ASUS_HEADSET_MIC),
>  	SND_PCI_QUIRK(0x1043, 0x19ce, "ASUS B9450FA", ALC294_FIXUP_ASUS_HPE),
>  	SND_PCI_QUIRK(0x1043, 0x1a13, "Asus G73Jw", ALC269_FIXUP_ASUS_G73JW),
>  	SND_PCI_QUIRK(0x1043, 0x1a30, "ASUS X705UD", ALC256_FIXUP_ASUS_MIC),
> -- 
> 2.26.0
>