linux-kernel - RE: [PATCH v2] vsprintf: don't obfuscate NULL and error pointers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fd21b6115b647baac23ee926b4c76f8@AcuMS.aculab.com>
Date:   Fri, 10 Apr 2020 09:40:01 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Linus Torvalds' <torvalds@...ux-foundation.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>
CC:     Ilya Dryomov <idryomov@...il.com>,
        Rasmus Villemoes <linux@...musvillemoes.dk>,
        Petr Mladek <pmladek@...e.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Randy Dunlap <rdunlap@...radead.org>,
        Kees Cook <keescook@...omium.org>,
        Sergey Senozhatsky <sergey.senozhatsky@...il.com>,
        "Tobin C . Harding" <me@...in.cc>
Subject: RE: [PATCH v2] vsprintf: don't obfuscate NULL and error pointers

From: Linus Torvalds
> Sent: 08 April 2020 17:23
> On Wed, Apr 8, 2020 at 8:08 AM Andy Shevchenko
> <andy.shevchenko@...il.com> wrote:
> >
> > For the better understanding the current state of affairs I suggest to respin
> > new version after rc1 and we will see again.

If the hash of a pointer ends up being one of the values that
wouldn't be hashed, perhaps it should be hashed again.
That will remove any possible confusion.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)