linux-kernel - Re: [PATCH] regulator: qcom_rpm: remove defined but not used 'pm8921

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200410012919.GW20625@builder.lan>
Date:   Thu, 9 Apr 2020 18:29:19 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Jason Yan <yanaijie@...wei.com>
Cc:     agross@...nel.org, lgirdwood@...il.com, broonie@...nel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regulator: qcom_rpm: remove defined but not used
 'pm8921_ftsmps'

On Thu 09 Apr 04:40 PDT 2020, Jason Yan wrote:

> Fix the following gcc warning:
> 
> drivers/regulator/qcom_rpm-regulator.c:607:34: warning: ‘pm8921_ftsmps’
> defined but not used [-Wunused-const-variable=]
>  static const struct qcom_rpm_reg pm8921_ftsmps = {
>                                   ^~~~~~~~~~~~~
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: Jason Yan <yanaijie@...wei.com>

Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>

> ---
>  drivers/regulator/qcom_rpm-regulator.c | 10 ----------
>  1 file changed, 10 deletions(-)
> 
> diff --git a/drivers/regulator/qcom_rpm-regulator.c b/drivers/regulator/qcom_rpm-regulator.c
> index 7fc97f23fcf4..1ee8ec686ed3 100644
> --- a/drivers/regulator/qcom_rpm-regulator.c
> +++ b/drivers/regulator/qcom_rpm-regulator.c
> @@ -604,16 +604,6 @@ static const struct qcom_rpm_reg pm8921_smps = {
>  	.supports_force_mode_bypass = false,
>  };
>  
> -static const struct qcom_rpm_reg pm8921_ftsmps = {
> -	.desc.linear_ranges = ftsmps_ranges,
> -	.desc.n_linear_ranges = ARRAY_SIZE(ftsmps_ranges),
> -	.desc.n_voltages = 101,
> -	.desc.ops = &uV_ops,
> -	.parts = &rpm8960_smps_parts,
> -	.supports_force_mode_auto = true,
> -	.supports_force_mode_bypass = false,
> -};
> -
>  static const struct qcom_rpm_reg pm8921_ncp = {
>  	.desc.linear_ranges = ncp_ranges,
>  	.desc.n_linear_ranges = ARRAY_SIZE(ncp_ranges),
> -- 
> 2.17.2
>