linux-kernel - Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200410112236.GX3628@piout.net>
Date:   Fri, 10 Apr 2020 13:22:36 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Aishwarya R <aishwaryarj100@...il.com>,
        Jonathan Cameron <jic23@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Nicolas Ferre <nicolas.ferre@...rochip.com>,
        Ludovic Desroches <ludovic.desroches@...rochip.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Allison Randal <allison@...utok.net>,
        Kefeng Wang <wangkefeng.wang@...wei.com>,
        Stephen Boyd <swboyd@...omium.org>,
        linux-iio <linux-iio@...r.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] iio: adc: at91-adc: Use devm_platform_ioremap_resource

On 10/04/2020 13:55:26+0300, Andy Shevchenko wrote:
> On Thu, Apr 9, 2020 at 7:00 PM Alexandre Belloni
> <alexandre.belloni@...tlin.com> wrote:
> > On 09/04/2020 20:41:23+0530, Aishwarya R wrote:
> > > Use the helper function that wraps the calls to
> > > platform_get_resource() and devm_ioremap_resource()
> > > together.
> 
> > Please elaborate the actual value of doing that.
> 
> Please, elaborate actual value of not doing that.
> 
> Yes, I know that you are p* off of these changes, but why you not
> going further and forbid all clean ups we are doing in the code?
> 
> To the point. Above change is reducing code base and showing the new
> comers modern APIs to use.
> 

The value of doing it is to reduce the code size by 16 bytes. The same
people doing that will actively ruin that by adding error string for
error that will never ever happen.

Also, the commit message is definitively lacking. A good commit message
would say that the patch has been generated using coccinelle, that no
testing has been done and that no thought has been given.

It would definitively make sense to send one patch per subsystem instead
of having 475 different patches each changing only one location.

The whole "let's let newcomers fix trivial bugs" thing is definitively
not working and it is not leading to an increase of the number of useful
reviewers and contributors

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com