linux-kernel - Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CADBw62qtpnnmsSmfnHBL_ntHyM9fZHohxghXv1Wgg-mCgbEnYA@mail.gmail.com>
Date:   Fri, 10 Apr 2020 10:15:19 +0800
From:   Baolin Wang <baolin.wang7@...il.com>
To:     Mark Brown <broonie@...nel.org>
Cc:     Lee Jones <lee.jones@...aro.org>, Arnd Bergmann <arnd@...db.de>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 1/3] mfd: syscon: Add reg_update_bits() callback support

On Thu, Apr 9, 2020 at 10:27 PM Mark Brown <broonie@...nel.org> wrote:
>
> On Thu, Apr 09, 2020 at 10:13:58PM +0800, Baolin Wang wrote:
> > On Thu, Apr 9, 2020 at 6:48 PM Mark Brown <broonie@...nel.org> wrote:
>
> > > > +     int (*reg_update_bits)(void *context, unsigned int reg,
> > > > +                            unsigned int mask, unsigned int val);
>
> > > This is fine, we already have this operation for buses, but why is this
> > > munged in with the MFD patch?
>
> > Originally I want to show a example usage of the new callback, but I
> > can spilt them into 2 patches as you suggested. Thanks.
>
> Yes, it's good to have an example user - just not as part of the same
> patch!

Yes, make sense.

-- 
Baolin Wang