linux-kernel - Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <Q7XK8Q.LJL60QVBDX02@crapouillou.net>
Date:   Fri, 10 Apr 2020 17:47:50 +0200
From:   Paul Cercueil <paul@...pouillou.net>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     harveyhuntnexus@...il.com, miquel.raynal@...tlin.com,
        richard@....at, vigneshr@...com, linux-mtd@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] mtd: rawnand: ingenic: Make qi_lb60_ooblayout_ops
 static

Hi,

Le ven. 10 avril 2020 à 19:51, YueHaibing <yuehaibing@...wei.com> a 
écrit :
> Fix sparse warning:
> 
> drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c:105:32:
>  warning: symbol 'qi_lb60_ooblayout_ops' was not declared. Should it 
> be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Acked-by: Paul Cercueil <paul@...pouillou.net>

Thanks!
-Paul

> ---
>  drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c 
> b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> index 935c4902ada7..e7bd845fdbf5 100644
> --- a/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> +++ b/drivers/mtd/nand/raw/ingenic/ingenic_nand_drv.c
> @@ -102,7 +102,7 @@ static int qi_lb60_ooblayout_free(struct mtd_info 
> *mtd, int section,
>  	return 0;
>  }
> 
> -const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
> +static const struct mtd_ooblayout_ops qi_lb60_ooblayout_ops = {
>  	.ecc = qi_lb60_ooblayout_ecc,
>  	.free = qi_lb60_ooblayout_free,
>  };
> --
> 2.17.1
> 
>