linux-kernel - Re: [PATCH] nbd: Fix memory leak from krealloc() if another allocation fails

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 10 Apr 2020 21:08:50 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Tuomas Tynkkynen <tuomas.tynkkynen@....fi>,
        linux-block@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, nbd@...er.debian.org,
        stable@...nel.org,
        syzbot+934037347002901b8d2a@...kaller.appspotmail.com,
        Josef Bacik <josef@...icpanda.com>,
        Jens Axboe <axboe@...nel.dk>
Subject: Re: [PATCH] nbd: Fix memory leak from krealloc() if another
 allocation fails

> syzkaller reports a memory leak when injecting allocation failures:
…
> as then config->num_connections is not incremented and the cleanup code
> freeing config->socks is skipped. Just make it run always.

How do you think about to add the tag “Fixes” for the final change description?

Regards,
Markus