linux-kernel - Re: [RFC v2 1/5] block: move main block debugfs initialization to its own file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ff5bfeb5-fb4d-931a-b34f-843596fad340@acm.org>
Date:   Thu, 9 Apr 2020 19:48:39 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Luis Chamberlain <mcgrof@...nel.org>, axboe@...nel.dk,
        viro@...iv.linux.org.uk, gregkh@...uxfoundation.org,
        rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz,
        ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org
Cc:     mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Omar Sandoval <osandov@...com>,
        Hannes Reinecke <hare@...e.com>,
        Michal Hocko <mhocko@...nel.org>
Subject: Re: [RFC v2 1/5] block: move main block debugfs initialization to its
 own file

On 2020-04-09 14:45, Luis Chamberlain wrote:
> Single and multiqeueue block devices share some debugfs code. By
> moving this into its own file it makes it easier to expand and audit
> this shared code.

Christoph doesn't like the name "single queue block devices".
Additionally, the legacy (single queue) block layer is gone. Should the
description of this patch perhaps refer to make_request-based drivers
and request-based drivers?

> +/*
> + * Shared debugfs mq / non-mq functionality
> + */

Shared request-based / make_request-based functionality?

Otherwise this patch looks good to me.

Thanks,

Bart.