linux-kernel - Re: [RFC v2 3/5] blktrace: ref count the request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e2928c9a-ffd5-c0b6-2107-a820da0c5b7f@acm.org>
Date:   Thu, 9 Apr 2020 19:58:13 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Luis Chamberlain <mcgrof@...nel.org>, axboe@...nel.dk,
        viro@...iv.linux.org.uk, gregkh@...uxfoundation.org,
        rostedt@...dmis.org, mingo@...hat.com, jack@...e.cz,
        ming.lei@...hat.com, nstange@...e.de, akpm@...ux-foundation.org
Cc:     mhocko@...e.com, yukuai3@...wei.com, linux-block@...r.kernel.org,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, Omar Sandoval <osandov@...com>,
        Hannes Reinecke <hare@...e.com>,
        Michal Hocko <mhocko@...nel.org>
Subject: Re: [RFC v2 3/5] blktrace: ref count the request_queue during ioctl

On 2020-04-09 14:45, Luis Chamberlain wrote:
> Ensure that the reqest_queue ref counts the request_queue
                  ^^^^^^^^^^^^ ^^^^^^^^^^
                request_queue? refcounts?
> during its full ioctl cycle. This avoids possible races against
> removal, given blk_get_queue() also checks to ensure the queue
> is not dying.
> 
> This small race is possible if you defer removal of the reqest_queue
                                                          ^^^^^^^^^^^^
                                                          request_queue?
> and userspace fires off an ioctl for the device in the meantime.

Anyway:

Reviewed-by: Bart Van Assche <bvanassche@....org>