linux-kernel - Re: [PATCH] timens: show clock symbolic names in /proc/pid/timens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <96bedbaf-49ea-f24b-b7b1-fb9a57fb6c7d@gmail.com>
Date:   Sat, 11 Apr 2020 12:36:32 +0200
From:   "Michael Kerrisk (man-pages)" <mtk.manpages@...il.com>
To:     Andrei Vagin <avagin@...il.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Andrew Morton <akpm@...ux-foundation.org>
Cc:     mtk.manpages@...il.com, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        "Eric W . Biederman" <ebiederm@...ssion.com>,
        Dmitry Safonov <0x7f454c46@...il.com>
Subject: Re: [PATCH] timens: show clock symbolic names in
 /proc/pid/timens_offsets

> As things stand, there is to my eye an excessive amount of white space
> in the output produced by this line:
> 
>> +	seq_printf(m, "%s\t%10lld\t%10ld\n", clock, ts->tv_sec, ts->tv_nsec);
> 
> Can I suggest instead something like:
> 
> 	seq_printf(m, "%-16s %10lld %9ld\n", clock, ts->tv_sec, ts->tv_nsec);

Actually, how about even s/-16s/-10s/ for that first field.

Thanks,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Linux/UNIX System Programming Training: http://man7.org/training/