linux-kernel - Re: [PATCH 1/6] ARM: dts: qcom: msm8974: Add pma8084 regulator node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200411013627.GH576963@builder.lan>
Date:   Fri, 10 Apr 2020 18:36:27 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Iskren Chernev <iskren.chernev@...il.com>
Cc:     linux-arm-msm@...r.kernel.org,
        Daniele Debernardi <drebrez@...il.com>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, ~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH 1/6] ARM: dts: qcom: msm8974: Add pma8084 regulator node

On Thu 09 Apr 19:31 PDT 2020, Iskren Chernev wrote:

> From: Daniele Debernardi <drebrez@...il.com>
> 
> The pma8084 regulator node is added with status disabled.  It is used in
> the Samsung Galaxy S5 (klte) for various things including gpio keys,
> sdhci, usb, dsi
> 

On the newer platforms we learned that the PMIC configuration wasn't
strictly tied to the platform.

I think we should migrate the older platforms as well (and your series
is an argument for doing this), so in line with that I think it would be
better if you moved this chunk to the klte dts (and squash it with the
second patch).

Regards,
Bjorn

> Signed-off-by: Daniele Debernardi <drebrez@...il.com>
> ---
>  arch/arm/boot/dts/qcom-msm8974.dtsi | 53 +++++++++++++++++++++++++++++
>  1 file changed, 53 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi
> index 2ea2308d91b3..fdb93138be25 100644
> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi
> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi
> @@ -1600,6 +1600,59 @@ pm8941-regulators {
>  					pm8941_lvs2: lvs2 {};
>  					pm8941_lvs3: lvs3 {};
>  				};
> +
> +				pma8084-regulators {
> +					compatible = "qcom,rpm-pma8084-regulators";
> +					status = "disabled";
> +
> +					pma8084_s1: s1 {};
> +					pma8084_s2: s2 {};
> +					pma8084_s3: s3 {};
> +					pma8084_s4: s4 {};
> +					pma8084_s5: s5 {};
> +					pma8084_s6: s6 {};
> +					pma8084_s7: s7 {};
> +					pma8084_s8: s8 {};
> +					pma8084_s9: s9 {};
> +					pma8084_s10: s10 {};
> +					pma8084_s11: s11 {};
> +					pma8084_s12: s12 {};
> +
> +					pma8084_l1: l1 {};
> +					pma8084_l2: l2 {};
> +					pma8084_l3: l3 {};
> +					pma8084_l4: l4 {};
> +					pma8084_l5: l5 {};
> +					pma8084_l6: l6 {};
> +					pma8084_l7: l7 {};
> +					pma8084_l8: l8 {};
> +					pma8084_l9: l9 {};
> +					pma8084_l10: l10 {};
> +					pma8084_l11: l11 {};
> +					pma8084_l12: l12 {};
> +					pma8084_l13: l13 {};
> +					pma8084_l14: l14 {};
> +					pma8084_l15: l15 {};
> +					pma8084_l16: l16 {};
> +					pma8084_l17: l17 {};
> +					pma8084_l18: l18 {};
> +					pma8084_l19: l19 {};
> +					pma8084_l20: l20 {};
> +					pma8084_l21: l21 {};
> +					pma8084_l22: l22 {};
> +					pma8084_l23: l23 {};
> +					pma8084_l24: l24 {};
> +					pma8084_l25: l25 {};
> +					pma8084_l26: l26 {};
> +					pma8084_l27: l27 {};
> +
> +					pma8084_lvs1: lvs1 {};
> +					pma8084_lvs2: lvs2 {};
> +					pma8084_lvs3: lvs3 {};
> +					pma8084_lvs4: lvs4 {};
> +
> +					pma8084_5vs1: 5vs1 {};
> +				};
>  			};
>  		};
>  	};
> -- 
> 2.26.0
>