linux-kernel - Re: [PATCH 4/7] kgdboc: Add earlycon_kgdboc to support early kgdb using boot consoles

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202004110910.bzdcPg1o%lkp@intel.com>
Date:   Sat, 11 Apr 2020 09:44:40 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Douglas Anderson <dianders@...omium.org>
Cc:     kbuild-all@...ts.01.org, jason.wessel@...driver.com,
        daniel.thompson@...aro.org, gregkh@...uxfoundation.org,
        hpa@...or.com, kgdb-bugreport@...ts.sourceforge.net,
        corbet@....net, frowand.list@...il.com, tglx@...utronix.de,
        jslaby@...e.com, linux-serial@...r.kernel.org, mingo@...hat.com,
        will@...nel.org, bjorn.andersson@...aro.org, agross@...nel.org,
        bp@...en8.de, catalin.marinas@....com,
        Douglas Anderson <dianders@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 4/7] kgdboc: Add earlycon_kgdboc to support early kgdb
 using boot consoles

Hi Douglas,

I love your patch! Yet something to improve:

[auto build test ERROR on arm64/for-next/core]
[also build test ERROR on tty/tty-testing v5.6 next-20200410]
[cannot apply to kgdb/kgdb-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Douglas-Anderson/kgdb-Support-late-serial-drivers-enable-early-debug-w-boot-consoles/20200411-062123
base:   https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git for-next/core
config: i386-allyesconfig (attached as .config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/usb/early/ehci-dbgp.c: In function 'kgdbdbgp_parse_config':
>> drivers/usb/early/ehci-dbgp.c:1060:2: error: too few arguments to function 'kgdb_register_io_module'
     kgdb_register_io_module(&kgdbdbgp_io_ops);
     ^~~~~~~~~~~~~~~~~~~~~~~
   In file included from drivers/usb/early/ehci-dbgp.c:24:0:
   include/linux/kgdb.h:326:12: note: declared here
    extern int kgdb_register_io_module(struct kgdb_io *new_dbg_io_ops,
               ^~~~~~~~~~~~~~~~~~~~~~~

vim +/kgdb_register_io_module +1060 drivers/usb/early/ehci-dbgp.c

4fe1da4ebc18c4 Jason Wessel 2010-05-20  1046  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1047  static int __init kgdbdbgp_parse_config(char *str)
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1048  {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1049  	char *ptr;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1050  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1051  	if (!ehci_debug) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1052  		if (early_dbgp_init(str))
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1053  			return -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1054  	}
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1055  	ptr = strchr(str, ',');
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1056  	if (ptr) {
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1057  		ptr++;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1058  		kgdbdbgp_wait_time = simple_strtoul(ptr, &ptr, 10);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1059  	}
4fe1da4ebc18c4 Jason Wessel 2010-05-20 @1060  	kgdb_register_io_module(&kgdbdbgp_io_ops);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1061  	kgdbdbgp_io_ops.is_console = early_dbgp_console.index != -1;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1062  
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1063  	return 0;
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1064  }
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1065  early_param("kgdbdbgp", kgdbdbgp_parse_config);
4fe1da4ebc18c4 Jason Wessel 2010-05-20  1066  

:::::: The code at line 1060 was first introduced by commit
:::::: 4fe1da4ebc18c4c42fa56c228447f68033fce5f0 echi-dbgp: Add kernel debugger support for the usb debug port

:::::: TO: Jason Wessel <jason.wessel@...driver.com>
:::::: CC: Jason Wessel <jason.wessel@...driver.com>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (71616 bytes)