linux-kernel - Re: [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <158657080736.199533.14290297278383794385@swboyd.mtv.corp.google.com>
Date:   Fri, 10 Apr 2020 19:06:47 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>,
        Michael Turquette <mturquette@...libre.com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: asm9260: fix __clk_hw_register_fixed_rate_with_accuracy typo

Quoting Arnd Bergmann (2020-04-08 08:53:43)
> The __clk_hw_register_fixed_rate_with_accuracy() function (with two '_')
> does not exist, and apparently never did:
> 
> drivers/clk/clk-asm9260.c: In function 'asm9260_acc_init':
> drivers/clk/clk-asm9260.c:279:7: error: implicit declaration of function '__clk_hw_register_fixed_rate_with_accuracy'; did you mean 'clk_hw_register_fixed_rate_with_accuracy'? [-Werror=implicit-function-declaration]
>   279 |  hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
>       |       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |       clk_hw_register_fixed_rate_with_accuracy
> drivers/clk/clk-asm9260.c:279:5: error: assignment to 'struct clk_hw *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
>   279 |  hw = __clk_hw_register_fixed_rate_with_accuracy(NULL, NULL, pll_clk,
>       |     ^
> 
> From what I can tell, __clk_hw_register_fixed_rate() is the correct
> API here, so use that instead.
> 
> Fixes: 728e3096741a ("clk: asm9260: Use parent accuracy in fixed rate clk")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---

Applied to clk-fixes