linux-kernel - Re: [PATCH] Staging: kernel: user: fixed some coding style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aef59a0b1364b0058a183f0e913a828b1b80f1b8.camel@perches.com>
Date:   Sat, 11 Apr 2020 12:53:57 -0700
From:   Joe Perches <joe@...ches.com>
To:     carlosteniswarrior@...il.com, gregkh@...uxfoundation.org
Cc:     akpm@...ux-foundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: kernel: user: fixed some coding style issues

On Sat, 2020-04-11 at 21:42 +0200, carlosteniswarrior@...il.com wrote:
> From: porfavorde <carlosteniswarrior@...il.com>

Hello.

> Fixed a coding style issue with a for loop and a trailing whitespace in
> the comments
> 
> Signed-off-by: Carlos Guerrero Álvarez <carlosteniswarrior@...il.com>

A From: line is generally used when sending a patch authored
by someone else.

It would be better here not to use a From: line at all as you
are both the author and sender.

Also please make your first patch somewhere in drivers/staging
and not any other directory until you are familiar with the
kernel styles and tools.  kernel/ isn't really a good place
for a first patch to be accepted, though I don't see anything
wrong with this patch other than the From: line.

But whitespace only changes outside of drivers/staging and a
few other directories are generally not accepted unless sent
as a patch series along with some other change such as
refactoring or a logical change for a defect.

cheers, Joe
---
>  kernel/user.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/user.c b/kernel/user.c
> index 5235d7f49982..4228ec04678d 100644
> --- a/kernel/user.c
> +++ b/kernel/user.c
> @@ -6,7 +6,7 @@
>   *
>   * We have a per-user structure to keep track of how many
>   * processes, files etc the user has claimed, in order to be
> - * able to have per-user limits for system resources. 
> + * able to have per-user limits for system resources.
>   */
>  
>  #include <linux/init.h>
> @@ -216,7 +216,7 @@ static int __init uid_cache_init(void)
>  	uid_cachep = kmem_cache_create("uid_cache", sizeof(struct user_struct),
>  			0, SLAB_HWCACHE_ALIGN|SLAB_PANIC, NULL);
>  
> -	for(n = 0; n < UIDHASH_SZ; ++n)
> +	for (n = 0; n < UIDHASH_SZ; ++n)
>  		INIT_HLIST_HEAD(uidhash_table + n);
>  
>  	/* Insert the root user immediately (init already runs as root) */