linux-kernel - Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 11 Apr 2020 06:07:47 +0200
From:   Bernd Edlinger <bernd.edlinger@...mail.de>
To:     Linus Torvalds <torvalds@...ux-foundation.org>,
        "Eric W. Biederman" <ebiederm@...ssion.com>
Cc:     Waiman Long <longman@...hat.com>, Ingo Molnar <mingo@...nel.org>,
        Will Deacon <will@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Alexey Gladkov <gladkov.alexey@...il.com>,
        Oleg Nesterov <oleg@...hat.com>
Subject: Re: [GIT PULL] Please pull proc and exec work for 5.7-rc1

On 4/10/20 2:32 AM, Linus Torvalds wrote:
> On Thu, Apr 9, 2020 at 5:30 PM Linus Torvalds
> <torvalds@...ux-foundation.org> wrote:
>>
>> Instead of trying to change how notify_count gets decremented, we
>> could do something like the attached patch: wait for it to go down to
>> zero, yes, but go back and re-check until you don't have to wait any
>> more. That should fix the underflow situation. The comment says it
>> all.
> 
> The "attached" patch wasn't.
> 
> Blush.
> 
> Here it is. Still entirely and utterly untested.
> 

Okay, if this works, please do not only make sure that our own test case
works, but also that the strace-5.5 test suite does not regress.

So currently at least one of the test cases was failing
before my totally crazy patch.
After my patch exactly the same test was failing.

So please make sure you don't break their tests.


Thanks
Bernd.

>            Linus
>