lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Sun, 12 Apr 2020 11:00:28 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc:     alexandru.ardelean@...log.com, lars@...afoo.de,
        Michael.Hennerich@...log.com, stefan.popa@...log.com,
        knaack.h@....de, pmeerw@...erw.net, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] iio: imu: adis: Add a missing '\n' in a log message

On Fri, 10 Apr 2020 19:12:24 +0200
Christophe JAILLET <christophe.jaillet@...adoo.fr> wrote:

> Message logged by 'dev_xxx()' or 'pr_xxx()' should end with a '\n'.
> 
> Fixes: 1fd456702692 ("iio: imu: adis: add support product ID check in adis_initial_startup")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Applied thanks,

Jonathan

> ---
>  drivers/iio/imu/adis.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/imu/adis.c b/drivers/iio/imu/adis.c
> index a8afd01de4f3..2e7d0d337f8f 100644
> --- a/drivers/iio/imu/adis.c
> +++ b/drivers/iio/imu/adis.c
> @@ -419,7 +419,7 @@ int __adis_initial_startup(struct adis *adis)
>  
>  	if (prod_id != adis->data->prod_id)
>  		dev_warn(&adis->spi->dev,
> -			 "Device ID(%u) and product ID(%u) do not match.",
> +			 "Device ID(%u) and product ID(%u) do not match.\n",
>  			 adis->data->prod_id, prod_id);
>  
>  	return 0;

Powered by blists - more mailing lists