linux-kernel - Re: [PATCH v2 05/11] MIPS: Switch to arch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200412193225.47fa4680@flygoat-x1e>
Date:   Sun, 12 Apr 2020 19:32:25 +0800
From:   Jiaxun Yang <jiaxun.yang@...goat.com>
To:     Marc Zyngier <maz@...nel.org>
Cc:     kbuild test robot <lkp@...el.com>, kbuild-all@...ts.01.org,
        linux-mips@...r.kernel.org,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Huacai Chen <chenhc@...ote.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        Namhyung Kim <namhyung@...nel.org>,
        Florian Fainelli <f.fainelli@...il.com>,
        Robert Richter <rric@...nel.org>,
        Sudeep Holla <sudeep.holla@....com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        Daniel Lezcano <daniel.lezcano@...aro.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Jason Cooper <jason@...edaemon.net>,
        Paul Burton <paulburton@...nel.org>,
        Allison Randal <allison@...utok.net>,
        Enrico Weigelt <info@...ux.net>,
        Kate Stewart <kstewart@...uxfoundation.org>,
        Vladimir Kondratiev <vladimir.kondratiev@...el.com>,
        Paul Cercueil <paul@...pouillou.net>,
        Zhou Yanjie <zhouyanjie@...o.com>,
        " 周琰杰 (Zhou Yanjie) " 
        <zhouyanjie@...yeetech.com>, YunQiang Su <syq@...ian.org>,
        Arnd Bergmann <arnd@...db.de>,
        Serge Semin <fancer.lancer@...il.com>,
        Matt Redfearn <matt.redfearn@...s.com>,
        Steve Winslow <swinslow@...il.com>,
        Alexios Zavras <alexios.zavras@...el.com>,
        Richard Fontana <rfontana@...hat.com>,
        Peter Xu <peterx@...hat.com>,
        afzal mohammed <afzal.mohd.ma@...il.com>,
        Kamal Dasu <kdasu.kdev@...il.com>,
        Oleksij Rempel <linux@...pel-privat.de>,
        linux-kernel@...r.kernel.org,
        bcm-kernel-feedback-list@...adcom.com, oprofile-list@...ts.sf.net,
        linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 05/11] MIPS: Switch to arch_topology

On Sun, 12 Apr 2020 10:39:08 +0100
Marc Zyngier <maz@...nel.org> wrote:

> On Sun, 12 Apr 2020 15:49:27 +0800
> Jiaxun Yang <jiaxun.yang@...goat.com> wrote:
> 
> > On Sun, 12 Apr 2020 13:24:21 +0800
> > kbuild test robot <lkp@...el.com> wrote:
> >   
> > > Hi Jiaxun,
> > > 
> > > I love your patch! Yet something to improve:
> > > 
> > > [auto build test ERROR on driver-core/driver-core-testing]
> > > [also build test ERROR on pm/linux-next linus/master
> > > next-20200411] [cannot apply to tip/perf/core tip/irq/core v5.6]
> > > [if your patch is applied to the wrong git tree, please drop us a
> > > note to help improve the system. BTW, we also suggest to use
> > > '--base' option to specify the base tree in git format-patch,
> > > please see https://stackoverflow.com/a/37406982]
> > > 
> > > url:
> > > https://github.com/0day-ci/linux/commits/Jiaxun-Yang/MIPS-Topology-DeviceTree-CPU-rework-v2/20200412-113308
> > > base:
> > > https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/driver-core.git
> > > a10c9c710f9ecea87b9f4bbb837467893b4bef01 config: mips-allnoconfig
> > > (attached as .config) compiler: mips-linux-gcc (GCC) 9.3.0
> > > reproduce: wget
> > > https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross
> > > -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached
> > > .config to linux build tree GCC_VERSION=9.3.0 make.cross
> > > ARCH=mips 
> > > 
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kbuild test robot <lkp@...el.com>
> > > 
> > > Note: the
> > > linux-review/Jiaxun-Yang/MIPS-Topology-DeviceTree-CPU-rework-v2/20200412-113308
> > > HEAD 8e8e9d4f7aa74359f2199773786ffe2fbb7877d0 builds fine. It only
> > > hurts bisectibility.
> > >     
> > Hi all,
> > 
> > In this case I think it should be fine to break bisect, otherwise
> > #05 will combine too many modifications in different subsystems.  
> 
> No. It is never OK to break bisection, specially when it affects a
> whole architecture.

I'm going to squash all these into patch #5.
It's really hard to do it gradually.

Thanks.

> 
> We introduce gradual changes over multiple subsystems all the time by
> using configuration symbols, no matter the number of patches. Yes, it
> is sometimes hard. But breaking the kernel and forcing everyone else
> to just deal with it is not acceptable.
> 
> Thanks,
> 
> 	M.
--
Jiaxun Yang