linux-kernel - Re: [PATCH 2/8] iio: core: drop devm_iio_triggered_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 12 Apr 2020 13:33:19 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Alexandru Ardelean <alexandru.ardelean@...log.com>
Cc:     <linux-iio@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/8] iio: core: drop devm_iio_triggered_buffer_cleanup()
 API call

On Thu, 27 Feb 2020 15:52:21 +0200
Alexandru Ardelean <alexandru.ardelean@...log.com> wrote:

> It's unused so far, so it can't be removed. Also makes sense to remove it
> to discourage weird uses of this call during review.
> 
> Signed-off-by: Alexandru Ardelean <alexandru.ardelean@...log.com>
Applied,

Thanks,

J
> ---
>  Documentation/driver-api/driver-model/devres.rst   |  1 -
>  drivers/iio/buffer/industrialio-triggered-buffer.c | 11 -----------
>  include/linux/iio/triggered_buffer.h               |  2 --
>  3 files changed, 14 deletions(-)
> 
> diff --git a/Documentation/driver-api/driver-model/devres.rst b/Documentation/driver-api/driver-model/devres.rst
> index 0580c64ebdfd..1431d5e44abc 100644
> --- a/Documentation/driver-api/driver-model/devres.rst
> +++ b/Documentation/driver-api/driver-model/devres.rst
> @@ -289,7 +289,6 @@ IIO
>    devm_iio_kfifo_allocate()
>    devm_iio_kfifo_free()
>    devm_iio_triggered_buffer_setup()
> -  devm_iio_triggered_buffer_cleanup()
>    devm_iio_trigger_alloc()
>    devm_iio_trigger_free()
>    devm_iio_trigger_register()
> diff --git a/drivers/iio/buffer/industrialio-triggered-buffer.c b/drivers/iio/buffer/industrialio-triggered-buffer.c
> index cb322b2f09cd..e8046c1ecd6b 100644
> --- a/drivers/iio/buffer/industrialio-triggered-buffer.c
> +++ b/drivers/iio/buffer/industrialio-triggered-buffer.c
> @@ -126,17 +126,6 @@ int devm_iio_triggered_buffer_setup(struct device *dev,
>  }
>  EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_setup);
>  
> -void devm_iio_triggered_buffer_cleanup(struct device *dev,
> -				       struct iio_dev *indio_dev)
> -{
> -	int rc;
> -
> -	rc = devres_release(dev, devm_iio_triggered_buffer_clean,
> -			    devm_iio_device_match, indio_dev);
> -	WARN_ON(rc);
> -}
> -EXPORT_SYMBOL_GPL(devm_iio_triggered_buffer_cleanup);
> -
>  MODULE_AUTHOR("Lars-Peter Clausen <lars@...afoo.de>");
>  MODULE_DESCRIPTION("IIO helper functions for setting up triggered buffers");
>  MODULE_LICENSE("GPL");
> diff --git a/include/linux/iio/triggered_buffer.h b/include/linux/iio/triggered_buffer.h
> index 238ad30ce166..e99c91799359 100644
> --- a/include/linux/iio/triggered_buffer.h
> +++ b/include/linux/iio/triggered_buffer.h
> @@ -18,7 +18,5 @@ int devm_iio_triggered_buffer_setup(struct device *dev,
>  				    irqreturn_t (*h)(int irq, void *p),
>  				    irqreturn_t (*thread)(int irq, void *p),
>  				    const struct iio_buffer_setup_ops *ops);
> -void devm_iio_triggered_buffer_cleanup(struct device *dev,
> -				       struct iio_dev *indio_dev);
>  
>  #endif