lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 12 Apr 2020 17:18:02 +0300
From:   Jarkko Sakkinen <>
To:     Shuah Khan <>
        Nikita Sobolev <>,
        Tadeusz Struk <>,
        open list <>
Subject: Re: [PATCH] selftests/tpm: Fix runtime error

On Sun, Apr 12, 2020 at 05:11:17PM +0300, Jarkko Sakkinen wrote:
> There is some random clutter in
>   ./ line 3: self.flags: command not found
> Remove it.
> Fixes: b32694cd0724 ("Kernel selftests: tpm2: check for tpm support")
> Cc: Nikita Sobolev <>
> Signed-off-by: Jarkko Sakkinen <>

Instead we should apply a revert to the original patch and Nikita could
refine it. Have additional questions e.g. why the constant is declared
instead of just exit 4? The commit message long description also fails
to document any sane reasoning for anything.

It is not enough to response the reasoning to me here. It needs to be
in the commit log. This is terrible.

It is obvious there has not been any kind of sane review process in


Powered by blists - more mailing lists