lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Sun, 12 Apr 2020 23:10:53 +0200
From:   Christian Brauner <>
To:     Eugene Syromiatnikov <>
        Christian Brauner <>,
        Andrew Morton <>,
        Ingo Molnar <>, Tejun Heo <>,
        Oleg Nesterov <>,
        Johannes Weiner <>,
        Li Zefan <>,
        Peter Zijlstra <>,,
        "Dmitry V. Levin" <>
Subject: Re: [PATCH] clone3: fix cgroup argument sanity check

On Sun, Apr 12, 2020 at 10:25:33PM +0200, Eugene Syromiatnikov wrote:
> Checking that cgroup field value of struct clone_args is less than 0
> is useless, as it is defined as unsigned 64-bit integer.  Moreover,
> it doesn't catch the situations where its higher bits are lost during
> the assignment to the cgroup field of the cgroup field of the internal
> struct kernel_clone_args (where it is declared as signed 32-bit
> integer), so it is still possible to pass garbage there.  A check
> against INT_MAX solves both these issues.
> Fixes: ef2c41cf38a7559b ("clone3: allow spawning processes into cgroups")
> Signed-off-by: Eugene Syromiatnikov <>

Thanks, will queue for rc2 unless I hear objections.
Acked-by: Christian Brauner <>

Powered by blists - more mailing lists