linux-kernel - Re: [PATCH AUTOSEL 5.6 056/149] sh_eth: check sh_eth_cpu_data::no

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6416ffc7-84a0-0383-aeda-93b4cb80c800@cogentembedded.com>
Date:   Sun, 12 Apr 2020 12:30:17 +0300
From:   Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:     Sasha Levin <sashal@...nel.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     Chris Brandt <chris.brandt@...esas.com>,
        "David S . Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.6 056/149] sh_eth: check
 sh_eth_cpu_data::no_xdfar when dumping registers

Hello!

On 12.04.2020 2:02, Sasha Levin wrote:

> From: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> 
> [ Upstream commit 7bf47f609f7eaac4f7e9c407a85ad78997288a38 ]
> 
> When adding the sh_eth_cpu_data::no_xdfar flag I forgot to add the flag
> check to  __sh_eth_get_regs(), causing the non-existing RDFAR/TDFAR to be
> considered for dumping on the R-Car gen1/2 SoCs (the register offset check
> has the final say here)...
> 
> Fixes: 4c1d45850d5 ("sh_eth: add sh_eth_cpu_data::cexcr flag")

    Oops, wrong commit here, should've been:

Fixes: 6e80e55bd37a ("sh_eth: add sh_eth_cpu_data::no_xdfar flag")

Luckily, both commits appeared in the same version, 4.17. :-)

> Signed-off-by: Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
> Tested-by: Chris Brandt <chris.brandt@...esas.com>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Sasha Levin <sashal@...nel.org>
[...]

MBR, Sergei