linux-kernel - RE: [PATCH] ASoC: bdw-rt5650: incorrect rate of PCM data

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BN6PR1101MB213296929CC4C10928F79C9A97DD0@BN6PR1101MB2132.namprd11.prod.outlook.com>
Date:   Mon, 13 Apr 2020 08:32:40 +0000
From:   "Lu, Brent" <brent.lu@...el.com>
To:     Keyon Jie <yang.jie@...ux.intel.com>,
        "alsa-devel@...a-project.org" <alsa-devel@...a-project.org>
CC:     "Rojewski, Cezary" <cezary.rojewski@...el.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        Liam Girdwood <liam.r.girdwood@...ux.intel.com>,
        Mark Brown <broonie@...nel.org>,
        "Jaroslav Kysela" <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        Ben Zhang <benzh@...omium.org>,
        "Chiang, Mac" <mac.chiang@...el.com>,
        "Guennadi Liakhovetski" <guennadi.liakhovetski@...ux.intel.com>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ASoC: bdw-rt5650: incorrect rate of PCM data

> 
> The patch looks good to me, except that the subject seems unrelated? you
> are changing the channel number, not the sample rate?
> 
> Thanks,
> ~Keyon
> 

Oops. The title is misleading. Google is using a program called alsa_conformance_test
to measure the data rate of all available audio configuration. The rate is incorrect
for 3-channel capture because BDW does not support it. Therefore, a constraint is
implemented here to remove the 3-channel capture support. I will upload a patch
with a more proper title.


Regards,
Brent