linux-kernel - Re: [PATCH 4.14 36/38] rpmsg: glink: Remove chunk size word align warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 10:20:23 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     nobuhiro1.iwamatsu@...hiba.co.jp
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        clew@...eaurora.org, aneela@...eaurora.org,
        bjorn.andersson@...aro.org, lee.jones@...aro.org
Subject: Re: [PATCH 4.14 36/38] rpmsg: glink: Remove chunk size word align
 warning

On Mon, Apr 13, 2020 at 05:16:05AM +0000, nobuhiro1.iwamatsu@...hiba.co.jp wrote:
> Hi,
> 
> > -----Original Message-----
> > From: stable-owner@...r.kernel.org [mailto:stable-owner@...r.kernel.org] On Behalf Of Greg Kroah-Hartman
> > Sent: Saturday, April 11, 2020 9:09 PM
> > To: linux-kernel@...r.kernel.org
> > Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>; stable@...r.kernel.org; Chris Lew <clew@...eaurora.org>; Arun
> > Kumar Neelakantam <aneela@...eaurora.org>; Bjorn Andersson <bjorn.andersson@...aro.org>; Lee Jones
> > <lee.jones@...aro.org>
> > Subject: [PATCH 4.14 36/38] rpmsg: glink: Remove chunk size word align warning
> > 
> > From: Chris Lew <clew@...eaurora.org>
> > 
> > commit f0beb4ba9b185d497c8efe7b349363700092aee0 upstream.
> > 
> > It is possible for the chunk sizes coming from the non RPM remote procs
> > to not be word aligned. Remove the alignment warning and continue to
> > read from the FIFO so execution is not stalled.
> > 
> > Signed-off-by: Chris Lew <clew@...eaurora.org>
> > Signed-off-by: Arun Kumar Neelakantam <aneela@...eaurora.org>
> > Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Signed-off-by: Lee Jones <lee.jones@...aro.org>
> > Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> This commit also seems to require the following commits:
> 
> commit 928002a5e9dab2ddc1a0fe3e00739e89be30dc6b
> Author: Arun Kumar Neelakantam <aneela@...eaurora.org>
> Date:   Wed Oct 3 17:08:20 2018 +0530
> 
>     rpmsg: glink: smem: Support rx peak for size less than 4 bytes
>     
>     The current rx peak function fails to read the data if size is
>     less than 4bytes.
>     
>     Use memcpy_fromio to support data reads of size less than 4 bytes.
>     
>     Cc: stable@...r.kernel.org
>     Fixes: f0beb4ba9b18 ("rpmsg: glink: Remove chunk size word align warning")
>     Signed-off-by: Arun Kumar Neelakantam <aneela@...eaurora.org>
>     Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> 
> This fixes commit need to apply 4.19.

This fix is already in 4.19.y, so it's only needed for 4.14.y at this
point in time, thanks!

greg k-h