linux-kernel - Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on s5pv210

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200413101127.GA10535@kozik-lap>
Date:   Mon, 13 Apr 2020 12:11:27 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Jonathan Bakker <xc-racer2@...e.ca>
Cc:     tomasz.figa@...il.com, s.nawrocki@...sung.com,
        linus.walleij@...aro.org, kgene@...nel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: samsung: Correct setting of eint wakeup mask on
 s5pv210

On Sat, Apr 04, 2020 at 10:08:49AM -0700, Jonathan Bakker wrote:
> Commit a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt
> mask") started writing the eint wakeup mask from the pinctrl driver.
> Unfortunately, it made the assumption that the private retention data
> was always a regmap while in the case of s5pv210 it is a raw pointer
> to the clock base (as the eint wakeup mask not in the PMU as with newer
> Exynos platforms).
> 
> Fixes: a8be2af0218c ("pinctrl: samsung: Write external wakeup interrupt mask")
> Signed-off-by: Jonathan Bakker <xc-racer2@...e.ca>
> ---
>  drivers/pinctrl/samsung/pinctrl-exynos.c | 73 ++++++++++++++++--------

Thanks, applied (with Cc-stable tag).

Best regards,
Krzysztof