linux-kernel - Re: [PATCH -next] soundwire: intel: Make sdw_intel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 10 Apr 2020 10:25:43 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     YueHaibing <yuehaibing@...wei.com>, vkoul@...nel.org,
        sanyog.r.kale@...el.com
Cc:     alsa-devel@...a-project.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH -next] soundwire: intel: Make sdw_intel_init static



On 4/10/20 6:57 AM, YueHaibing wrote:
> Fix sparse warning:
> 
> drivers/soundwire/intel_init.c:193:6: warning:
>   symbol 'sdw_intel_init' was not declared. Should it be static?
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>
> ---
>   drivers/soundwire/intel_init.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index 4b769409f6f8..ad7053463889 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -190,7 +190,8 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
>    * This scans the namespace and creates SoundWire link controller devices
>    * based on the info queried.
>    */
> -void *sdw_intel_init(acpi_handle *parent_handle, struct sdw_intel_res *res)
> +static void *sdw_intel_init(acpi_handle *parent_handle,
> +			    struct sdw_intel_res *res)

This declaration has been this way since 2017, there are no users and it 
will be removed with the Intel patchsets, so fixing this warning doesn't 
really add much value. No sustained objection though.

>   {
>   	acpi_status status;
>   
>