linux-kernel - Re: ASoC: s3c-i2s-v2 regression, was: [GIT PULL] sound updates for 5.6-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200413121530.GA5200@kozik-lap>
Date:   Mon, 13 Apr 2020 14:15:30 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Arnd Bergmann <arnd@...db.de>
Cc:     Takashi Iwai <tiwai@...e.de>, Mark Brown <broonie@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
        Sangbeom Kim <sbkim73@...sung.com>,
        Sylwester Nawrocki <s.nawrocki@...sung.com>
Subject: Re: ASoC: s3c-i2s-v2 regression, was: [GIT PULL] sound updates for
 5.6-rc1

On Sat, Apr 11, 2020 at 10:41:52AM +0200, Arnd Bergmann wrote:
> On Tue, Jan 28, 2020 at 9:21 AM Takashi Iwai <tiwai@...e.de> wrote:
> 
> > Kuninori Morimoto (66):
> >       ASoC: bcm: cygnus-ssp: move .suspend/.resume to component
> >       ASoC: atmel: atmel_ssc_dai: move .suspend/.resume to component
> >       ASoC: cirrus: ep93xx-i2s: move .suspend/.resume to component
> >       ASoC: jz4740: jz4740-i2s: move .suspend/.resume to component
> >       ASoC: mediatek: move .suspend/.resume to component
> >       ASoC: samsung: s3c24xx-i2s: move .suspend/.resume to component
> >       ASoC: samsung: spdif: move .suspend/.resume to component
> >       ASoC: sti: sti_uniperif: move .suspend/.resume to component
> >       ASoC: ti: omap-mcpdm: move .suspend/.resume to component
> >       ASoC: uniphier: move .suspend/.resume to component
> >       ASoC: dwc: dwc-i2s: move .suspend/.resume to component
> >       ASoC: samsung: i2s: move .suspend/.resume to component
> >       ASoC: ux500: ux500_msp_dai: remove unused DAI .suspend/.resume
> >       ASoC: pxa: pxa-ssp: move .suspend/.resume to component
> >       ASoC: pxa: pxa2xx-i2s: move .suspend/.resume to component
> >       ASoC: soc-core: remove DAI suspend/resume
> 
> I only found it now during randconfig testing, but it seems that there is
> (at least) one patching in this conversion series that was part of linux-5.6:
> 
> sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_component':
> sound/soc/samsung/s3c-i2s-v2.c:726:9: error: 'struct
> snd_soc_dai_driver' has no member named 'suspend'
>   726 |  dai_drv->suspend = s3c2412_i2s_suspend;
>       |         ^~
> sound/soc/samsung/s3c-i2s-v2.c:727:9: error: 'struct
> snd_soc_dai_driver' has no member named 'resume'
>   727 |  dai_drv->resume = s3c2412_i2s_resume;
>       |         ^~
> 
> I tried fixing it myself but could not see an obvious solution. Can someone
> else who understands this code better than me have a look?

This can be triggered after enabling SND_SOC_SAMSUNG and
SND_SOC_SAMSUNG_JIVE_WM8750.

I can fix it but only compile-tested.

Best regards,
Krzysztof