[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20200413125616.GA3127208@kroah.com>
Date: Mon, 13 Apr 2020 14:56:16 +0200
From: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To: Oscar Carter <oscar.carter@....com>
Cc: Forest Bond <forest@...ttletooquiet.net>,
devel@...verdev.osuosl.org, Malcolm Priestley <tvboxspy@...il.com>,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] staging: vt6656: Refactor the assignment of the
phy->signal variable
On Sat, Apr 11, 2020 at 02:26:09PM +0200, Oscar Carter wrote:
> Create a constant array with the values of the "phy->signal" for every
> rate. Remove all "phy->signal" assignments inside the switch statement
> and replace these with a single reading from the new vnt_phy_signal
> array.
>
> The constant array can be of one dimension because the OR mask with
> BIT(3) or BIT(4) allow obtain a second value according to the rate,
> the preamble_type and the pkt_type.
>
> Signed-off-by: Oscar Carter <oscar.carter@....com>
> ---
> drivers/staging/vt6656/baseband.c | 105 ++++++++----------------------
> 1 file changed, 26 insertions(+), 79 deletions(-)
This series did not apply to my tree, please rebase and resend.
thanks,
greg k-h
Powered by blists - more mailing lists