linux-kernel - Re: [PATCH v4 4/8] usb: mausb_host: Implement initial hub handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 17:16:08 +0200
From:   Vladimir Stankovic <vladimir.stankovic@...playlink.com>
To:     Alan Stern <stern@...land.harvard.edu>
Cc:     gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
        linux-usb@...r.kernel.org, mausb-host-devel@...playlink.com
Subject: Re: [PATCH v4 4/8] usb: mausb_host: Implement initial hub handlers

On 27.3.20. 17:37, Alan Stern wrote:
> On Fri, 27 Mar 2020 vladimir.stankovic@...playlink.com wrote:
> 
>> Implemented handlers for subset of HCD events.
>>
>> Signed-off-by: Vladimir Stankovic <vladimir.stankovic@...playlink.com>
>> ---
>> +/*
>> + * For usb 2.0 logitech camera called multiple times, once during
>> + * enumeration of device and later after mausb_reset_device.
>> + */
>> +static int mausb_address_device(struct usb_hcd *hcd, struct usb_device *dev)
> 
>> +/*
>> + * For usb 2.0 logitech camera called multiple times, once during enumeration
>> + * of device and later after mausb_reset_device. In latter case it is
>> + * required to address the device again in order for ep0 to work properly.
>> + */
>> +static int mausb_enable_device(struct usb_hcd *hcd, struct usb_device *dev)
> 
>> +/*
>> + * For usb 2.0 logitech camera called multiple times,
>> + * followed by either mausb_enable_device or mausb_address_device.
>> + * Resets device to non-addressed state.
>> + */
>> +static int mausb_reset_device(struct usb_hcd *hcd, struct usb_device *dev)
> 
> Why on earth do you have all these comments about Logitech cameras?  A 
> host controller driver shouldn't care about the type of devices it gets 
> connected to.
> 
> Alan Stern
> 
You're right. As it turns out, it is leftover during development.
Implementation has been tested with cameras from other vendors as well.

We'll remove those in next patch version.
 
Regards,
Vladimir.