linux-kernel - Re: [PATCH] iio: adc: sun4i-gpadc-iio: Use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 16:33:51 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Aishwarya R <aishwaryarj100@...il.com>
Cc:     Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Maxime Ripard <mripard@...nel.org>,
        Chen-Yu Tsai <wens@...e.org>, Enrico Weigelt <info@...ux.net>,
        Allison Randal <allison@...utok.net>,
        Yangtao Li <tiny.windzz@...il.com>,
        Stephen Boyd <swboyd@...omium.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: sun4i-gpadc-iio: Use
 devm_platform_ioremap_resource

On Sun, 12 Apr 2020 20:02:18 +0530
Aishwarya R <aishwaryarj100@...il.com> wrote:

> From: Aishwarya Ramakrishnan <aishwaryarj100@...il.com>
> 
> Use the helper function that wraps the calls to platform_get_resource()
> and devm_ioremap_resource() together.Reduces boilerplate and suggested
> by coccinelle.
> 
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@...il.com>

So couple of general things for future reference.
1. New versions of a patch need a title such as [PATCH V2]
2. You have several similar patches, they would have been best sent
   as a series as that lets a maintainer pick them all up in one go.
3. Don't send new versions in reply to older versions.  It doesn't scale
   as we regularly end up 10 or more versions in to a series.  Not to mention
   many reviewers read backwards in time (as often earlier patches are resolved
   before you get to them) so by sending it as a reply you ensured it was much
   less likely to be applied.  Here you were luck as I am on holiday so have
   time to catch up.

Applied to the togreg branch of iio.git with the message above tidied up
a little.  Will be pushed out as testing for the autobuilders to poke at it.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/sun4i-gpadc-iio.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/iio/adc/sun4i-gpadc-iio.c b/drivers/iio/adc/sun4i-gpadc-iio.c
> index 176e1cb4abb1..0f2c1738a90d 100644
> --- a/drivers/iio/adc/sun4i-gpadc-iio.c
> +++ b/drivers/iio/adc/sun4i-gpadc-iio.c
> @@ -496,7 +496,6 @@ static int sun4i_gpadc_probe_dt(struct platform_device *pdev,
>  				struct iio_dev *indio_dev)
>  {
>  	struct sun4i_gpadc_iio *info = iio_priv(indio_dev);
> -	struct resource *mem;
>  	void __iomem *base;
>  	int ret;
>  
> @@ -508,8 +507,7 @@ static int sun4i_gpadc_probe_dt(struct platform_device *pdev,
>  	indio_dev->num_channels = ARRAY_SIZE(sun8i_a33_gpadc_channels);
>  	indio_dev->channels = sun8i_a33_gpadc_channels;
>  
> -	mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(&pdev->dev, mem);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
>