linux-kernel - Re: [PATCH] sched/fair: add __init to sched_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200413114444.5db76182@gandalf.local.home>
Date:   Mon, 13 Apr 2020 11:44:44 -0400
From:   Steven Rostedt <rostedt@...dmis.org>
To:     宋牧春 <songmuchun@...edance.com>
Cc:     mingo@...nel.org, peterz@...radead.org, juri.lelli@...hat.com,
        Vincent Guittot <vincent.guittot@...aro.org>,
        dietmar.eggemann@....com, Benjamin Segall <bsegall@...gle.com>,
        mgorman@...e.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sched/fair: add __init to sched_init_granularity
 functions

On Mon, 13 Apr 2020 23:07:03 +0800
宋牧春 <songmuchun@...edance.com> wrote:

> > -void sched_init_granularity(void)
> > +void __init sched_init_granularity(void)
> >  {
> >         update_sysctl();
> >  }
> > --
> > 2.11.0
> >  
> 
> Ping guys. Any suggestions?

Seems fine, but not that big of an issue as it's a very small function.

ffffffff81136880 <sched_init_granularity>:
ffffffff81136880:       e8 7b b3 ac 00          callq  ffffffff81c01c00 <__fentry__>
                        ffffffff81136881: R_X86_64_PLT32        __fentry__-0x4
ffffffff81136885:       e9 86 86 ff ff          jmpq   ffffffff8112ef10 <update_sysctl>
ffffffff8113688a:       66 0f 1f 44 00 00       nopw   0x0(%rax,%rax,1)


But anyway, it can save 16 bytes of memory in the running kernel.

Reviewed-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve