linux-kernel - Re: [PATCH] dm verity fec: fix hash block number in verity_fec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 13:31:27 +0900
From:   Sunwook Eom <speed.eom@...sung.com>
To:     Sami Tolvanen <samitolvanen@...gle.com>
Cc:     Alasdair Kergon <agk@...hat.com>,
        Mike Snitzer <snitzer@...hat.com>,
        device-mapper development <dm-devel@...hat.com>,
        강문철 <mcneo.kang@...sung.com>,
        sunwook5492@...il.com, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dm verity fec: fix hash block number in
 verity_fec_decode


On 20. 4. 11. 오전 12:41, Sami Tolvanen wrote:
> On Thu, Apr 9, 2020 at 8:54 PM Sunwook Eom <speed.eom@...sung.com> wrote:
>> The error correction data is computed as if data and hash blocks
>> were concatenated. But hash block number is start from v->hash_start.
>> So, we have to calculate hash block number based on that.
>>
>> Fixes: a739ff3f543af ("dm verity: add support for forward error correction")
>> Signed-off-by: Sunwook Eom <speed.eom@...sung.com>
>> ---
>>    drivers/md/dm-verity-fec.c | 2 +-
>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/md/dm-verity-fec.c b/drivers/md/dm-verity-fec.c
>> index 49147e634046..fb41b4f23c48 100644
>> --- a/drivers/md/dm-verity-fec.c
>> +++ b/drivers/md/dm-verity-fec.c
>> @@ -435,7 +435,7 @@ int verity_fec_decode(struct dm_verity *v, struct
>> dm_verity_io *io,
>>        fio->level++;
>>
>>        if (type == DM_VERITY_BLOCK_TYPE_METADATA)
>> -        block += v->data_blocks;
>> +        block = block - v->hash_start + v->data_blocks;
>>
>>        /*
>>         * For RS(M, N), the continuous FEC data is divided into blocks of N
> Thank you for the patch!
>
> Reviewed-by: Sami Tolvanen <samitolvanen@...gle.com>
>
> Sami
>
>
Add CC : LKML <linux-kernel@...r.kernel.org>