linux-kernel - Re: [PATCHSET v2 block/for-5.8] iocost: improve use

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 13 Apr 2020 20:00:29 +0300
From:   Pavel Begunkov <asml.silence@...il.com>
To:     Tejun Heo <tj@...nel.org>, axboe@...nel.dk
Cc:     linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
        kernel-team@...com, cgroups@...r.kernel.org, newella@...com,
        josef@...icpanda.com, ming.lei@...hat.com, bvanassche@....org
Subject: Re: [PATCHSET v2 block/for-5.8] iocost: improve use_delay and latency
 target handling

On 13/04/2020 19:56, Pavel Begunkov wrote:
> On 13/04/2020 19:27, Tejun Heo wrote:
>> Changes from v1[1]
>>
>> * Dropped 0002-block-add-request-io_data_len.patch and updated to use
>>   rq->stats_sectors instead as suggested by Pavel Begunkov.
> 
> rq->stats_sectors is set only when there is QUEUE_FLAG_STATS, see
> blk_mq_start_request(). I don't see blk-iocost requiring it. Did I miss something?

And there is no reason to not initialise it unconditionally.

-- 
Pavel Begunkov



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)