linux-kernel - Re: [PATCH] net/3com/3c515: Fix MODULE_ARCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200413052637.GG334007@unreal>
Date:   Mon, 13 Apr 2020 08:26:37 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     David Miller <davem@...emloft.net>
Cc:     bp@...en8.de, kuba@...nel.org, thomas.lendacky@....com,
        keyur@...amperecomputing.com, pcnet32@...ntier.com,
        vfalico@...il.com, j.vosburgh@...il.com, linux-acenic@...site.dk,
        mripard@...nel.org, heiko@...ech.de, mark.einon@...il.com,
        chris.snook@...il.com, linux-rockchip@...ts.infradead.org,
        iyappan@...amperecomputing.com, irusskikh@...vell.com,
        dave@...dillows.org, netanel@...zon.com,
        quan@...amperecomputing.com, jcliburn@...il.com,
        LinoSanfilippo@....de, linux-arm-kernel@...ts.infradead.org,
        andreas@...sler.com, andy@...yhouse.net, netdev@...r.kernel.org,
        thor.thayer@...ux.intel.com, linux-kernel@...r.kernel.org,
        ionut@...ula.org, akiyano@...zon.com, jes@...ined-monkey.org,
        nios2-dev@...ts.rocketboards.org, wens@...e.org
Subject: Re: [PATCH] net/3com/3c515: Fix MODULE_ARCH_VERMAGIC redefinition

On Sun, Apr 12, 2020 at 10:07:39PM -0700, David Miller wrote:
> From: Leon Romanovsky <leon@...nel.org>
> Date: Mon, 13 Apr 2020 07:55:55 +0300
>
> > On Sun, Apr 12, 2020 at 09:03:41PM -0700, David Miller wrote:
> >> From: Borislav Petkov <bp@...en8.de>
> >> Date: Sat, 11 Apr 2020 17:56:23 +0200
> >>
> >> > From: Borislav Petkov <bp@...e.de>
> >> >
> >> > Change the include order so that MODULE_ARCH_VERMAGIC from the arch
> >> > header arch/x86/include/asm/module.h gets used instead of the fallback
> >> > from include/linux/vermagic.h and thus fix:
> >> >
> >> >   In file included from ./include/linux/module.h:30,
> >> >                    from drivers/net/ethernet/3com/3c515.c:56:
> >> >   ./arch/x86/include/asm/module.h:73: warning: "MODULE_ARCH_VERMAGIC" redefined
> >> >      73 | # define MODULE_ARCH_VERMAGIC MODULE_PROC_FAMILY
> >> >         |
> >> >   In file included from drivers/net/ethernet/3com/3c515.c:25:
> >> >   ./include/linux/vermagic.h:28: note: this is the location of the previous definition
> >> >      28 | #define MODULE_ARCH_VERMAGIC ""
> >> >         |
> >> >
> >> > Fixes: 6bba2e89a88c ("net/3com: Delete driver and module versions from 3com drivers")
> >> > Signed-off-by: Borislav Petkov <bp@...e.de>
> >>
> >> I'm so confused, that commit in the Fixes: tag is _removing_ code but adding
> >> new #include directives?!?!
> >>
> >> Is vermagic.h really needed in these files?
> >
> > You are completely right, it is not needed at all in those files.
>
> Ok let's just remove it to fix this.

Thanks a lot.

How do you want us to handle it? Boris resend, me to send, you to fix?

Thanks