linux-kernel - Re: [PATCH v1] i2c: img-scb: remove duplicate dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <08564c03-3bbd-5518-1a9d-a40b8ca09f48@web.de>
Date:   Tue, 14 Apr 2020 17:48:41 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Dejin Zheng <zhengdejin5@...il.com>, linux-i2c@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Allison Randal <allison@...utok.net>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Patrice Chotard <patrice.chotard@...com>,
        Shah Nehal-Bakulchandra <Nehal-bakulchandra.Shah@....com>,
        Tang Bin <tangbin@...s.chinamobile.com>,
        Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH v1] i2c: img-scb: remove duplicate dev_err()

> it will print an error message by itself when platform_get_irq()
> goes wrong. so don't need dev_err() in here again.

I suggest to improve the change description.
Can you get any further inspiration by previous patches from
other contributors according to the presented transformation pattern?

Would you like to adjust any more source files in the mentioned
software area?

Regards,
Markus