linux-kernel - Re: [PATCH v2 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VdBvJRVxSTcWkPyW=ePhr2oPmKpEar=XsXF+KV+w1306w@mail.gmail.com>
Date:   Tue, 14 Apr 2020 19:43:11 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     mani@...nel.org
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Rob Herring <robh+dt@...nel.org>, narcisaanamaria12@...il.com,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald <pmeerw@...erw.net>,
        linux-iio <linux-iio@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: chemical: Add OF match table for CCS811 VOC sensor

On Tue, Apr 14, 2020 at 6:34 PM <mani@...nel.org> wrote:
>
> From: Manivannan Sadhasivam <mani@...nel.org>
>
> Add devicetree OF match table support for CCS811 VOC sensor.
>

This looks good to me. FWIW,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Manivannan Sadhasivam <mani@...nel.org>
> ---
>  drivers/iio/chemical/ccs811.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/chemical/ccs811.c b/drivers/iio/chemical/ccs811.c
> index 951358710f64..310e9dedc9ba 100644
> --- a/drivers/iio/chemical/ccs811.c
> +++ b/drivers/iio/chemical/ccs811.c
> @@ -538,9 +538,16 @@ static const struct i2c_device_id ccs811_id[] = {
>  };
>  MODULE_DEVICE_TABLE(i2c, ccs811_id);
>
> +static const struct of_device_id ccs811_dt_ids[] = {
> +       { .compatible = "ams,ccs811" },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(of, ccs811_dt_ids);
> +
>  static struct i2c_driver ccs811_driver = {
>         .driver = {
>                 .name = "ccs811",
> +               .of_match_table = ccs811_dt_ids,
>         },
>         .probe = ccs811_probe,
>         .remove = ccs811_remove,
> --
> 2.17.1
>


-- 
With Best Regards,
Andy Shevchenko