linux-kernel - Re: [PATCH] scripts: documentation-file-ref-check: Add line break before exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20200414184951.7f3a5564@coco.lan>
Date:   Tue, 14 Apr 2020 18:49:51 +0200
From:   Mauro Carvalho Chehab <mchehab+huawei@...nel.org>
To:     Tiezhu Yang <yangtiezhu@...ngson.cn>
Cc:     Jonathan Corbet <corbet@....net>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Xuefeng Li <lixuefeng@...ngson.cn>
Subject: Re: [PATCH] scripts: documentation-file-ref-check: Add line break
 before exit

Em Tue, 14 Apr 2020 17:41:48 +0800
Tiezhu Yang <yangtiezhu@...ngson.cn> escreveu:

> If execute ./scripts/documentation-file-ref-check in a directory which is
> not a git tree, it will exit without a line break, fix it.
> 
> Without this patch:
> 
> [loongson@...alhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree[loongson@...alhost linux-5.7-rc1]$
> 
> With this patch:
> 
> [loongson@...alhost linux-5.7-rc1]$ ./scripts/documentation-file-ref-check
> Warning: can't check if file exists, as this is not a git tree
> [loongson@...alhost linux-5.7-rc1]$
> 
> Signed-off-by: Tiezhu Yang <yangtiezhu@...ngson.cn>

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@...nel.org>

> ---
>  scripts/documentation-file-ref-check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/documentation-file-ref-check b/scripts/documentation-file-ref-check
> index 9a8cc10..c71832b 100755
> --- a/scripts/documentation-file-ref-check
> +++ b/scripts/documentation-file-ref-check
> @@ -25,7 +25,7 @@ my $fix = 0;
>  my $warn = 0;
>  
>  if (! -d ".git") {
> -	printf "Warning: can't check if file exists, as this is not a git tree";
> +	printf "Warning: can't check if file exists, as this is not a git tree\n";
>  	exit 0;
>  }
>  



Thanks,
Mauro