linux-kernel - Re: [PATCH] ASoC: sgtl5000: Fix VAG power-on handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 16:01:10 -0300
From:   Fabio Estevam <festevam@...il.com>
To:     Sebastian Reichel <sebastian.reichel@...labora.com>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Linux-ALSA <alsa-devel@...a-project.org>,
        linux-kernel <linux-kernel@...r.kernel.org>, kernel@...labora.com
Subject: Re: [PATCH] ASoC: sgtl5000: Fix VAG power-on handling

Hi Sebastian,

On Tue, Apr 14, 2020 at 3:11 PM Sebastian Reichel
<sebastian.reichel@...labora.com> wrote:
>
> As mentioned slightly out of patch context in the code, there
> is no reset routine for the chip. On boards where the chip is
> supplied by a fixed regulator, it might not even be resetted
> during (e.g. watchdog) reboot and can be in any state.
>
> If the device is probed with VAG enabled, the driver's probe
> routine will generate a loud pop sound when ANA_POWER is
> being programmed. Avoid this by properly disabling just the
> VAG bit and waiting the required power down time.
>
> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>

Reviewed-by: Fabio Estevam <festivem@...il.com>