[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <19df87f5d093a6c2721316811aca1c90d287bf1d.camel@perches.com>
Date: Tue, 14 Apr 2020 12:09:49 -0700
From: Joe Perches <joe@...ches.com>
To: Dan Carpenter <dan.carpenter@...cle.com>,
Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Thierry Reding <thierry.reding@...il.com>, paul@...pouillou.net,
u.kleine-koenig@...gutronix.de, linux-pwm@...r.kernel.org,
linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] pwm: Add missing '\n' in log messages
On Tue, 2020-04-14 at 21:49 +0300, Dan Carpenter wrote:
> Huh...
>
> If you look at dev_vprintk_emit(). It looks like if
> create_syslog_header() returns a string then vprintk_store() will add
> a newline.
>
> I guess that means that dev_printk() can't be used to pr_cont(). And
> probably that's deliberate because using pr_cont() after boot is racy
> anyway.
Perhaps that's true, it didn't used to be.
There are couple dozen or so KERN_CONT uses after a dev_<level>
without a newline, so those _might_ be broken, but I don't thinks so.
$ git grep -P -A10 '\bdev_\w+\s*\(' | \
grep -P -B10 "KERN_CONT|pr_cont"
Powered by blists - more mailing lists