linux-kernel - Re: [PATCH] cifs: improve read performance for page size 64KB & cache=strict & vers=2.1+

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <CAH2r5mt1k5t8rSH1KizeSrcLaN1Fn3GWeMvDPwT2Kfq43UAWaQ@mail.gmail.com>
Date:   Tue, 14 Apr 2020 14:58:33 -0500
From:   Steve French <smfrench@...il.com>
To:     Jones Syue <jonessyue@...p.com>
Cc:     Pavel Shilovsky <piastryyy@...il.com>,
        linux-cifs <linux-cifs@...r.kernel.org>,
        Samba Technical <samba-technical@...ts.samba.org>,
        Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] cifs: improve read performance for page size 64KB &
 cache=strict & vers=2.1+

Did you also test (at least briefly) with vers=1.0 since some of your
code affects that code path too?

And if anyone figures out how to configure an x86_64 Linux to use
PAGE_SIZE of 64K or larger let me know...

On Sun, Apr 12, 2020 at 9:24 PM Jones Syue via samba-technical
<samba-technical@...ts.samba.org> wrote:
>
> Hello Pavel
>
> Thanks for kindly reviewing!
> Please find the attached v2.patch.
>
> --
> Regards,
> Jones Syue | 薛懷宗
> QNAP Systems, Inc.
>
>
> On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <piastryyy@...il.com> wrote:
> >
> > Hi Jones,
> >
> > Thanks for the patch!
> >
> > It will work although it is probably a little bit cleaner to
> > initialize server->max_read to server->maxBuf for SMB1 and use the
> > server->max_read in the readpages condition check instead.
> >
> > @Others, thoughts?
> >
> > --
> > Best regards,
> > Pavel Shilovsky



-- 
Thanks,

Steve