linux-kernel - [PATCH] tools/build: tweak unused value workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20200414195638.156123-1-gbiv@google.com>
Date:   Tue, 14 Apr 2020 12:56:38 -0700
From:   George Burgess IV <gbiv@...gle.com>
To:     akpm@...ux-foundation.org
Cc:     ndesaulniers@...gle.com, linux-kernel@...r.kernel.org,
        George Burgess IV <gbiv@...gle.com>
Subject: [PATCH] tools/build: tweak unused value workaround

Clang has -Wself-assign enabled by default under -Wall, which always
gets -Werror'ed on this file, causing sync-compare-and-swap to be
disabled by default. The generally-accepted way to spell "this value is
intentionally unused," is casting it to `void`. This is accepted by both
GCC and Clang with -Wall enabled: https://godbolt.org/z/qqZ9r3

Signed-off-by: George Burgess IV <gbiv@...gle.com>
---
 tools/build/feature/test-sync-compare-and-swap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/build/feature/test-sync-compare-and-swap.c b/tools/build/feature/test-sync-compare-and-swap.c
index 1e38d1930a97..3bc6b0768a53 100644
--- a/tools/build/feature/test-sync-compare-and-swap.c
+++ b/tools/build/feature/test-sync-compare-and-swap.c
@@ -7,7 +7,7 @@ int main(int argc, char *argv[])
 {
 	uint64_t old, new = argc;
 
-	argv = argv;
+	(void)argv;
 	do {
 		old = __sync_val_compare_and_swap(&x, 0, 0);
 	} while (!__sync_bool_compare_and_swap(&x, old, new));
-- 
2.26.0.110.g2183baf09c-goog