linux-kernel - Re: [PATCH] x86/unwind/orc: make some symbols static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 14 Apr 2020 17:24:07 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Miroslav Benes <mbenes@...e.cz>
Cc:     Jason Yan <yanaijie@...wei.com>, tglx@...utronix.de,
        mingo@...hat.com, bp@...en8.de, hpa@...or.com, x86@...nel.org,
        peterz@...radead.org, shile.zhang@...ux.alibaba.com,
        linux-kernel@...r.kernel.org, Hulk Robot <hulkci@...wei.com>
Subject: Re: [PATCH] x86/unwind/orc: make some symbols static

On Tue, Apr 14, 2020 at 11:22:50AM +0200, Miroslav Benes wrote:
> On Mon, 13 Apr 2020, Jason Yan wrote:
> 
> > Fix the following sparse warning:
> > 
> > arch/x86/kernel/unwind_orc.c:19:5: warning: symbol 'cur_orc_ip_table'
> > was not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:20:18: warning: symbol 'cur_orc_table' was
> > not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:22:14: warning: symbol 'lookup_num_blocks'
> > was not declared. Should it be static?
> > arch/x86/kernel/unwind_orc.c:23:6: warning: symbol 'orc_init' was not
> > declared. Should it be static?
> > 
> > Reported-by: Hulk Robot <hulkci@...wei.com>
> > Signed-off-by: Jason Yan <yanaijie@...wei.com>
> > ---
> >  arch/x86/kernel/unwind_orc.c | 8 ++++----
> >  1 file changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/x86/kernel/unwind_orc.c b/arch/x86/kernel/unwind_orc.c
> > index e9cc182aa97e..0dbabc469ce2 100644
> > --- a/arch/x86/kernel/unwind_orc.c
> > +++ b/arch/x86/kernel/unwind_orc.c
> > @@ -16,11 +16,11 @@ extern struct orc_entry __start_orc_unwind[];
> >  extern struct orc_entry __stop_orc_unwind[];
> >  
> >  static DEFINE_MUTEX(sort_mutex);
> > -int *cur_orc_ip_table = __start_orc_unwind_ip;
> > -struct orc_entry *cur_orc_table = __start_orc_unwind;
> > +static int *cur_orc_ip_table = __start_orc_unwind_ip;
> > +static struct orc_entry *cur_orc_table = __start_orc_unwind;
> >  
> > -unsigned int lookup_num_blocks;
> > -bool orc_init;
> > +static unsigned int lookup_num_blocks;
> > +static bool orc_init;
> >  
> >  static inline unsigned long orc_ip(const int *ip)
> >  {
> > -- 
> 
> Thanks for the patch, but Josh already fixed it in 
> https://lore.kernel.org/lkml/63b5cab2e28b9c08854fc57f5b512a9ccf76ad95.1584033751.git.jpoimboe@redhat.com/
> 
> Josh, any plans to add the patch set into the current queue?

Yeah, I have a v2 coming one of these days...

-- 
Josh