linux-kernel - Re: [RESEND][PATCH v2] phy: qcom-qusb2: Re add "qcom,sdm845-qusb2-phy" compat string

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20200414235239.GJ892431@yoga>
Date:   Tue, 14 Apr 2020 16:52:39 -0700
From:   Bjorn Andersson <bjorn.andersson@...aro.org>
To:     Doug Anderson <dianders@...omium.org>
Cc:     John Stultz <john.stultz@...aro.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Manu Gautam <mgautam@...eaurora.org>,
        Sandeep Maheswaram <sanm@...eaurora.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Kishon Vijay Abraham I <kishon@...com>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>
Subject: Re: [RESEND][PATCH v2] phy: qcom-qusb2: Re add
 "qcom,sdm845-qusb2-phy" compat string

On Tue 14 Apr 12:06 PDT 2020, Doug Anderson wrote:

> Hi,
> 
> On Tue, Apr 14, 2020 at 11:57 AM John Stultz <john.stultz@...aro.org> wrote:
> >
> > This patch fixes a regression in 5.7-rc1.
> >
> > In commit 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2
> > PHY support"), the change was made to add "qcom,qusb2-v2-phy"
> > as a generic compat string. However the change also removed
> > the "qcom,sdm845-qusb2-phy" compat string, which is documented
> > in the binding and already in use.
> >
> > This patch re-adds the "qcom,sdm845-qusb2-phy" compat string
> > which allows the driver to continue to work with existing dts
> > entries such as found on the db845c.
> >
> > Cc: Andy Gross <agross@...nel.org>
> > Cc: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Cc: Rob Herring <robh+dt@...nel.org>
> > Cc: Mark Rutland <mark.rutland@....com>
> > Cc: Doug Anderson <dianders@...omium.org>
> > Cc: Manu Gautam <mgautam@...eaurora.org>
> > Cc: Sandeep Maheswaram <sanm@...eaurora.org>
> > Cc: Matthias Kaehlcke <mka@...omium.org>
> > Cc: Stephen Boyd <swboyd@...omium.org>
> > Cc: Kishon Vijay Abraham I <kishon@...com>
> > Cc: linux-arm-msm@...r.kernel.org
> > Cc: devicetree@...r.kernel.org
> > Reviewed-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> > Fixes: 8fe75cd4cddf ("phy: qcom-qusb2: Add generic QUSB2 V2 PHY support")
> > Reported-by: YongQin Liu <yongqin.liu@...aro.org>
> > Signed-off-by: John Stultz <john.stultz@...aro.org>
> 
> Re-adding reviews from:
> https://lore.kernel.org/r/158631458374.216820.17829557619378130779@swboyd.mtv.corp.google.com
> https://lore.kernel.org/r/CAD=FV=Wh9_4a-cDGPdpMrXUi_HmJvS-a2Ubeyo5WG3sgwVWKKQ@mail.gmail.com
> 
> Reviewed-by: Stephen Boyd <swboyd@...omium.org>
> Reviewed-by: Douglas Anderson <dianders@...omium.org>
> 
> ...as of an hour ago Bjorn also picked up:
> 
> https://lore.kernel.org/r/1583747589-17267-8-git-send-email-sanm@codeaurora.org
> 
> ...and it's now in the Qualcomm for-next and ci-next.  It's still a
> bit of a pain that -rc1 will have the regression since many other
> maintainers will base their next branches on that, but not much to be
> done about it now.
> 

The regression is in the driver, so we want this patch landed in v5.7.
The dts change is heading for 5.8.

Regards,
Bjorn