linux-kernel - Re: [PATCH v1 1/1] scsi: ufs: full reinit upon resume if link was off

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <98c11950db39f63fa7f6959b223e7372@codeaurora.org>
Date:   Tue, 14 Apr 2020 13:56:03 +0800
From:   Can Guo <cang@...eaurora.org>
To:     Alim Akhtar <alim.akhtar@...sung.com>
Cc:     asutoshd@...eaurora.org, nguyenb@...eaurora.org,
        hongwus@...eaurora.org, rnayak@...eaurora.org,
        linux-scsi@...r.kernel.org, kernel-team@...roid.com,
        saravanak@...gle.com, salyzyn@...gle.com,
        'Avri Altman' <avri.altman@....com>,
        "'James E.J. Bottomley'" <jejb@...ux.ibm.com>,
        "'Martin K. Petersen'" <martin.petersen@...cle.com>,
        'Stanley Chu' <stanley.chu@...iatek.com>,
        'Bean Huo' <beanhuo@...ron.com>,
        'Bart Van Assche' <bvanassche@....org>,
        'Venkat Gopalakrishnan' <venkatg@...eaurora.org>,
        'Tomas@...eaurora.org, Winkler' <tomas.winkler@...el.com>,
        'open list' <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] scsi: ufs: full reinit upon resume if link was off

Hi Alim,

On 2020-04-14 10:30, Alim Akhtar wrote:
> Hi Can,
> 
>> -----Original Message-----
>> From: Can Guo <cang@...eaurora.org>
>> Sent: 28 March 2020 07:58
>> To: asutoshd@...eaurora.org; nguyenb@...eaurora.org;
>> hongwus@...eaurora.org; rnayak@...eaurora.org; linux-
>> scsi@...r.kernel.org; kernel-team@...roid.com; saravanak@...gle.com;
>> salyzyn@...gle.com; cang@...eaurora.org
>> Cc: Alim Akhtar <alim.akhtar@...sung.com>; Avri Altman
>> <avri.altman@....com>; James E.J. Bottomley <jejb@...ux.ibm.com>; 
>> Martin
>> K. Petersen <martin.petersen@...cle.com>; Stanley Chu
>> <stanley.chu@...iatek.com>; Bean Huo <beanhuo@...ron.com>; Bart Van
>> Assche <bvanassche@....org>; Venkat Gopalakrishnan
>> <venkatg@...eaurora.org>; Tomas Winkler <tomas.winkler@...el.com>; 
>> open
>> list <linux-kernel@...r.kernel.org>
>> Subject: [PATCH v1 1/1] scsi: ufs: full reinit upon resume if link was 
>> off
>> 
>> From: Asutosh Das <asutoshd@...eaurora.org>
>> 
>> During suspend, if the link is put to off, it would require a full
> initialization during

Good catch.

>> resume. This patch resets and restores both the hba and the card 
>> during
>> initialization.
>> 
> In case you have faced issues by not doing what this patch does, it is 
> worth
> mentioning that in the commit mesg.
> 

OK.

>> Signed-off-by: Asutosh Das <asutoshd@...eaurora.org>
>> Signed-off-by: Can Guo <cang@...eaurora.org>
>> ---
> I don't have a way to test this path as of now, changes looks ok 
> though.
> Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>
> 
>>  drivers/scsi/ufs/ufshcd.c | 8 ++++++--
>>  1 file changed, 6 insertions(+), 2 deletions(-)
>> 
>> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c 
>> index
>> f19a11e..21e41e5 100644
>> --- a/drivers/scsi/ufs/ufshcd.c
>> +++ b/drivers/scsi/ufs/ufshcd.c
>> @@ -8007,9 +8007,13 @@ static int ufshcd_resume(struct ufs_hba *hba, 
>> enum
>> ufs_pm_op pm_op)
>>  		else
>>  			goto vendor_suspend;
>>  	} else if (ufshcd_is_link_off(hba)) {
>> -		ret = ufshcd_host_reset_and_restore(hba);
>>  		/*
>> -		 * ufshcd_host_reset_and_restore() should have already
>> +		 * A full initialization of the host and the device is
> required

Shall fix.

>> +		 * since the link was put to off during suspend.
>> +		 */
>> +		ret = ufshcd_reset_and_restore(hba);
>> +		/*
>> +		 * ufshcd_reset_and_restore() should have already
>>  		 * set the link state as active
>>  		 */
>>  		if (ret || !ufshcd_is_link_active(hba))
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a 
>> Linux
>> Foundation Collaborative Project.

Thanks.
Can Guo.